From: Andres Lagar-Cavilla <andres@lagarcavilla.org>
To: xen-devel@lists.xensource.com
Cc: olaf@aepfle.de, George.Dunlap@eu.citrix.com,
andres@gridcentric.ca, tim@xen.org, keir.xen@gmail.com,
adin@gridcentric.ca
Subject: [PATCH 4 of 6] When passing no bitmap for the shadow log dirty bitmap clean up, we should not get EFAULT
Date: Mon, 14 Nov 2011 16:48:45 -0500 [thread overview]
Message-ID: <f11528df1df311f0d579.1321307325@xdev.gridcentric.ca> (raw)
In-Reply-To: <patchbomb.1321307321@xdev.gridcentric.ca>
tools/libxc/xc_domain.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
This is due to a stale check for guest_handle_null in the hypervisor, which doesn't
necessarily work with the hypercall buffers.
Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
diff -r 43dd4fdbf539 -r f11528df1df3 tools/libxc/xc_domain.c
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -430,6 +430,8 @@ int xc_shadow_control(xc_interface *xch,
DECLARE_DOMCTL;
DECLARE_HYPERCALL_BUFFER_ARGUMENT(dirty_bitmap);
+ memset(&domctl, 0, sizeof(domctl));
+
domctl.cmd = XEN_DOMCTL_shadow_op;
domctl.domain = (domid_t)domid;
domctl.u.shadow_op.op = sop;
next prev parent reply other threads:[~2011-11-14 21:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 21:48 [PATCH 0 of 6] P2M various fixes Andres Lagar-Cavilla
2011-11-14 21:48 ` [PATCH 1 of 6] The PoD code may split a 1GB superpage in a potentially unlocked way Andres Lagar-Cavilla
2011-11-15 15:39 ` George Dunlap
2011-11-14 21:48 ` [PATCH 2 of 6] Fix handling of m2p map in set_shared_p2m_entry Andres Lagar-Cavilla
2011-11-14 21:48 ` [PATCH 3 of 6] Make HAP log dirty disable return the correct rc Andres Lagar-Cavilla
2011-11-15 10:33 ` George Dunlap
2011-11-14 21:48 ` Andres Lagar-Cavilla [this message]
2011-11-14 21:48 ` [PATCH 5 of 6] Rework stale p2m auditing Andres Lagar-Cavilla
2011-11-15 12:14 ` George Dunlap
2011-11-15 15:38 ` Andres Lagar-Cavilla
2011-11-24 15:30 ` Tim Deegan
2011-11-24 16:21 ` Andres Lagar-Cavilla
2011-11-24 16:26 ` Tim Deegan
2011-11-14 21:48 ` [PATCH 6 of 6] Add libxc wrapper for p2m audit domctl Andres Lagar-Cavilla
2011-11-24 15:32 ` [PATCH 0 of 6] P2M various fixes Tim Deegan
2011-11-24 15:55 ` Andres Lagar-Cavilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f11528df1df311f0d579.1321307325@xdev.gridcentric.ca \
--to=andres@lagarcavilla.org \
--cc=George.Dunlap@eu.citrix.com \
--cc=adin@gridcentric.ca \
--cc=andres@gridcentric.ca \
--cc=keir.xen@gmail.com \
--cc=olaf@aepfle.de \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).