From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
To: xen-devel@lists.xensource.com
Cc: ian.jackson@eu.citrix.com
Subject: [PATCH] blktap2: fix gap in tapdisk2 disk_type numbering
Date: Fri, 25 Feb 2011 10:41:37 -0800 [thread overview]
Message-ID: <f16d772fdb6c58518299.1298659297@athos.nss.cs.ubc.ca> (raw)
# HG changeset patch
# User Shriram Rajagopalan <rshriram@cs.ubc.ca>
# Date 1298659167 28800
# Node ID f16d772fdb6c58518299d4c3780b846bcbee6165
# Parent d9c73cceb29715bfafada4d80e79787cb4666816
blktap2: fix gap in tapdisk2 disk_type numbering
Make the DISK_TYPE_* id numbering in tapdisk-disktypes.h contiguous.
Currently, id 8 is unallocated causing a null disk type entry in
tapdisk_disk_drivers array in tapdisk-disktypes.c. This causes the
function tapdisk_disktype_find() to return an error on encountering
disk types >7 (remus:, log:, etc.).
Signed-off-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>
diff -r d9c73cceb297 -r f16d772fdb6c tools/blktap2/drivers/tapdisk-disktype.h
--- a/tools/blktap2/drivers/tapdisk-disktype.h Fri Feb 25 10:29:53 2011 -0800
+++ b/tools/blktap2/drivers/tapdisk-disktype.h Fri Feb 25 10:39:27 2011 -0800
@@ -37,9 +37,9 @@
#define DISK_TYPE_RAM 5
#define DISK_TYPE_QCOW 6
#define DISK_TYPE_BLOCK_CACHE 7
-#define DISK_TYPE_LOG 9
-#define DISK_TYPE_REMUS 10
-#define DISK_TYPE_VINDEX 11
+#define DISK_TYPE_LOG 8
+#define DISK_TYPE_REMUS 9
+#define DISK_TYPE_VINDEX 10
#define DISK_TYPE_NAME_MAX 32
next reply other threads:[~2011-02-25 18:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 18:41 Shriram Rajagopalan [this message]
2011-02-25 19:38 ` [PATCH] blktap2: fix gap in tapdisk2 disk_type numbering Daniel Stodden
2011-02-25 20:11 ` Shriram Rajagopalan
2011-02-28 16:28 ` Shriram Rajagopalan
2011-03-03 16:48 ` Ian Jackson
2011-03-03 21:30 ` Daniel Stodden
2011-03-07 16:16 ` [PATCH] blktap2: fix gap in tapdisk2 disk_type numbering [and 1 more messages] Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f16d772fdb6c58518299.1298659297@athos.nss.cs.ubc.ca \
--to=rshriram@cs.ubc.ca \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).