From: Jan Beulich <jbeulich@suse.com>
To: Frediano Ziglio <frediano.ziglio@citrix.com>,
xen-devel@lists.xenproject.org
Cc: "Frediano Ziglio" <frediano.ziglio@cloud.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Anthony PERARD" <anthony.perard@vates.tech>,
"Michal Orzel" <michal.orzel@amd.com>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Frediano Ziglio" <freddy77@gmail.com>,
"Demi Marie Obenour" <demiobenour@gmail.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v4] xen: Strip xen.efi by default
Date: Mon, 10 Nov 2025 13:40:44 +0100 [thread overview]
Message-ID: <f1785ee8-2c70-41e5-9cb6-0506dc110ef0@suse.com> (raw)
In-Reply-To: <20251110123034.77692-1-frediano.ziglio@citrix.com>
On 10.11.2025 13:30, Frediano Ziglio wrote:
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -228,17 +228,23 @@ endif
> $(MAKE) $(build)=$(@D) .$(@F).1r.o .$(@F).1s.o
> $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds $< \
> $(dot-target).1r.o $(dot-target).1s.o $(orphan-handling-y) \
> - $(note_file_option) -o $@
> - $(NM) -pa --format=sysv $@ \
> + $(note_file_option) -o $@.tmp
> + $(NM) -pa --format=sysv $@.tmp \
Why is this needed in this shape? Can't you use $(TARGET)-syms.efi here
right away, ...
> | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \
> > $@.map
> ifeq ($(CONFIG_DEBUG_INFO),y)
> - $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(OBJCOPY) -O elf64-x86-64 $@ $@.elf
> + $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(OBJCOPY) \
> + -O elf64-x86-64 $@.tmp $@.elf
> + $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))mv -f \
> + $@.tmp $(TARGET)-syms.efi
... avoiding the need for this mv and ...
> + $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(STRIP) \
> + $(TARGET)-syms.efi -o $@.tmp
... double use of $@.tmp?
> endif
> - rm -f $(dot-target).[0-9]* $(@D)/..$(@F).[0-9]*
> ifeq ($(CONFIG_XEN_IBT),y)
> - $(SHELL) $(srctree)/tools/check-endbr.sh $@
> + $(SHELL) $(srctree)/tools/check-endbr.sh $@.tmp
> endif
> + mv -f $@.tmp $@
> + rm -f $(dot-target).[0-9]* $(@D)/..$(@F).[0-9]*
At least part of the rearrangement here also looks unrelated, and isn't
mentioned at all in the description.
Jan
prev parent reply other threads:[~2025-11-10 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 12:30 [PATCH v4] xen: Strip xen.efi by default Frediano Ziglio
2025-11-10 12:40 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1785ee8-2c70-41e5-9cb6-0506dc110ef0@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=demiobenour@gmail.com \
--cc=freddy77@gmail.com \
--cc=frediano.ziglio@citrix.com \
--cc=frediano.ziglio@cloud.com \
--cc=julien@xen.org \
--cc=marmarek@invisiblethingslab.com \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).