From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [OSSTEST PATCH RFC 04/14] ap-common: add xtf tree
Date: Thu, 4 Aug 2016 16:43:26 +0100 [thread overview]
Message-ID: <f440f10e-af69-09f0-cfd7-b9aa9b2f6b9e@citrix.com> (raw)
In-Reply-To: <22435.23941.116175.875379@mariner.uk.xensource.com>
On 04/08/16 16:21, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [OSSTEST PATCH RFC 04/14] ap-common: add xtf tree"):
>> On 04/08/16 12:49, Ian Jackson wrote:
>>> Andrew, do you want to have osstest run its xtf push gate between
>>> `staging' and `master' branches of xtf, or do you want to just push to
>>> xtf master, and have a separate `osstest/tested' or some such branch
>>> for the osstest push gate output ?
>> The latter please.
> NP.
>
>> We should also clarify the force push criteria. It is moderately likely
>> that we get a fix or extension to an existing test which starts showing
>> up a new bug in the code under test.
> Can this not be made into a new test ?
That very much depends, and probably needs deciding on a case by case basis.
What absolutely shouldn't happen is ending up with test-$FOO,
test-$FOO-2, test-more-$FOO, test-$FOO-again because that will result in
the same logical test being split up in ad-hoc ways. While XTF is
useful for automation, it is first and foremost a tool for humans.
~Andrew
>
> osstest would like such an extension to an existing test to be a new
> `step' (in osstest terminology). That would mean that the fact that
> it fails with old versions of Xen can be seen not to be a regression.
>
> Ie, osstest would like to be able to distinguish:
> * this version of xtf didn't have the new part of the test
> * old part of the test failed (and presumably new part was not run)
> * old part succeeded and new part failed
> * both parts were run and succeeded
>
>> In this case, OSSTest will identify a regression, but it isn't a
>> regression isn't in XTF, nor is it reasonable to call it a regression in
>> Xen. We would absolutely want to fix it in upstream, but there are no
>> guarentees that the bugfix would be suitable for backport to older trees.
> Indeed.
>
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-04 15:43 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 8:45 [OSSTEST PATCH RFC 00/14] Integrate XTF into OSSTest Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 01/14] ts-xen-build: always compile in FEP support Wei Liu
2016-08-04 11:46 ` Ian Jackson
2016-08-04 11:49 ` Wei Liu
2016-08-04 11:53 ` Andrew Cooper
2016-08-04 12:03 ` Wei Liu
2016-08-04 13:28 ` Andrew Cooper
2016-08-04 14:03 ` Wei Liu
2016-08-04 14:08 ` Andrew Cooper
2016-08-04 15:22 ` Ian Jackson
2016-08-04 15:26 ` Wei Liu
2016-08-04 15:36 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 02/14] TestSupport: factor out target_jobdir_subdir Wei Liu
2016-08-04 11:47 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 03/14] DO NOT APPLY ts-leak-check: sleep 5 seconds before collecting stuff Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 04/14] ap-common: add xtf tree Wei Liu
2016-08-04 11:49 ` Ian Jackson
2016-08-04 13:34 ` Andrew Cooper
2016-08-04 15:21 ` Ian Jackson
2016-08-04 15:43 ` Andrew Cooper [this message]
2016-08-04 16:13 ` Ian Jackson
2016-08-04 18:20 ` Andrew Cooper
2016-08-04 14:06 ` Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 05/14] DO NOT APPLY point xtf to my personal tree Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build Wei Liu
2016-08-04 11:52 ` Ian Jackson
2016-08-04 11:57 ` Wei Liu
2016-08-04 15:04 ` Ian Jackson
2016-08-04 15:17 ` [OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build [and 1 more messages] Ian Jackson
2016-08-04 15:35 ` Wei Liu
2016-08-04 16:05 ` Ian Jackson
2016-08-04 18:10 ` Andrew Cooper
2016-08-04 18:12 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 07/14] sg-run-job: create xtf build recipe Wei Liu
2016-08-04 11:53 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 08/14] Introduce ts-xtf-install Wei Liu
2016-08-04 11:54 ` Ian Jackson
2016-08-04 11:58 ` Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 09/14] mfi-common: create xtf build job for 4.8 onwards Wei Liu
2016-08-04 11:59 ` Ian Jackson
2016-08-04 14:12 ` Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 10/14] Introduce ts-xtf-fep Wei Liu
2016-08-04 12:00 ` Ian Jackson
2016-08-04 12:03 ` Wei Liu
2016-08-04 8:45 ` [OSSTEST PATCH RFC 11/14] Introduce ts-xtf-run Wei Liu
2016-08-04 12:19 ` Ian Jackson
2016-08-04 14:40 ` Wei Liu
2016-08-04 15:31 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 12/14] sg-run-job: test-xtf recipe Wei Liu
2016-08-04 12:20 ` Ian Jackson
2016-08-04 8:45 ` [OSSTEST PATCH RFC 13/14] make-flight: create 5 xtf jobs Wei Liu
2016-08-04 12:24 ` Ian Jackson
2016-08-04 8:46 ` [OSSTEST PATCH RFC 14/14] Create XTF branch Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f440f10e-af69-09f0-cfd7-b9aa9b2f6b9e@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).