Re: [PATCH v3 09/11] events/x86: Define SCI virtual interrupt

[Boris Ostrovsky <boris.ostrovsky@oracle.com>]

On 11/22/2016 10:25 AM, Jan Beulich wrote:
>>>> On 21.11.16 at 22:00, <boris.ostrovsky@oracle.com> wrote:
>> PVH guests do not have IOAPIC which typically generates an SCI. For
>> those guests SCI will be provided as a virtual interrupt.
>>
>> We also move VIRQ_MCA definition out of xen-mca.h to
>> keep all x86-specific VIRQ_ARCH_* in one place.
>
> While I appreciate the idea, you can't: xen-mca.h doesn't include
> xen.h, and hence parties consuming xen-mca.h alone may then see
> their build broken.

Right.

Any reason we can't include "xen.h" here?

-boris

Considering that duplicate identical #define-s are
> fine, I think there's no way around ...
>
>> --- a/xen/include/public/arch-x86/xen-mca.h
>> +++ b/xen/include/public/arch-x86/xen-mca.h
>> @@ -91,8 +91,6 @@
>>
>>  #ifndef __ASSEMBLY__
>>
>> -#define VIRQ_MCA VIRQ_ARCH_0 /* G. (DOM0) Machine Check Architecture */
>
> .. keeping this, while perhaps still ...
>
>> --- a/xen/include/public/arch-x86/xen.h
>> +++ b/xen/include/public/arch-x86/xen.h
>> @@ -295,6 +295,9 @@ struct xen_arch_domainconfig {
>>  };
>>  #endif
>>
>> +#define VIRQ_MCA VIRQ_ARCH_0 /* G. (DOM0) Machine Check Architecture */
>> +#define VIRQ_SCI VIRQ_ARCH_1 /* G. (PVH) ACPI interrupt */
>
> ... adding both here.
>
> Jan
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel