From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Roger Pau Monne <roger.pau@citrix.com>,
xen-devel@lists.xenproject.org, konrad.wilk@oracle.com
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v4 3/4] x86/pt: enable binding of GSIs to a PVH Dom0
Date: Thu, 1 Jun 2017 18:13:22 -0400 [thread overview]
Message-ID: <f67e62b2-ab8d-ab9e-3d96-317639237c05@oracle.com> (raw)
In-Reply-To: <20170601114914.18601-4-roger.pau@citrix.com>
> @@ -696,7 +777,7 @@ int hvm_do_IRQ_dpci(struct domain *d, struct pirq *pirq)
> struct hvm_irq_dpci *dpci = domain_get_irq_dpci(d);
> struct hvm_pirq_dpci *pirq_dpci = pirq_dpci(pirq);
>
> - if ( !iommu_enabled || !dpci || !pirq_dpci ||
> + if ( !iommu_enabled || (!is_hardware_domain(d) && !dpci) || !pirq_dpci ||
> !(pirq_dpci->flags & HVM_IRQ_DPCI_MAPPED) )
> return 0;
We also need to return for !is_hvm_domain(d).
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-01 22:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 11:49 [PATCH v4 0/4] x86/dpci: bind legacy PCI interrupts to PVHv2 Dom0 Roger Pau Monne
2017-06-01 11:49 ` [PATCH v4 1/4] x86/pt: remove hvm_domid field from bind struct Roger Pau Monne
2017-06-01 11:57 ` Wei Liu
2017-06-01 13:17 ` Jan Beulich
2017-06-01 14:45 ` Roger Pau Monne
2017-06-01 11:49 ` [PATCH v4 2/4] x86/physdev: factor out the code to allocate and map a pirq Roger Pau Monne
2017-06-01 14:20 ` Jan Beulich
2017-06-01 14:40 ` Andrew Cooper
2017-06-01 15:20 ` Roger Pau Monne
2017-06-01 11:49 ` [PATCH v4 3/4] x86/pt: enable binding of GSIs to a PVH Dom0 Roger Pau Monne
2017-06-01 22:13 ` Boris Ostrovsky [this message]
2017-06-02 8:41 ` Roger Pau Monne
2017-06-02 12:46 ` Boris Ostrovsky
2017-06-02 13:58 ` [PATCH v4.1 " Roger Pau Monne
2017-06-07 13:17 ` Jan Beulich
2017-06-19 16:45 ` Roger Pau Monne
2017-06-20 7:19 ` Jan Beulich
2017-06-01 11:49 ` [PATCH v4 4/4] x86/vioapic: bind interrupts to " Roger Pau Monne
2017-06-07 13:20 ` Jan Beulich
2017-06-19 17:04 ` Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f67e62b2-ab8d-ab9e-3d96-317639237c05@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).