xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Sergej Proskurin <proskurin@sec.in.tum.de>,
	Tamas K Lengyel <tamas@tklengyel.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [RFC PATCH 4/4] arm/mem_access: Add software guest-page-table walk
Date: Tue, 9 May 2017 09:09:52 +0100	[thread overview]
Message-ID: <f6bf077c-d1a6-492c-9ad0-63e65f4c6ae9@arm.com> (raw)
In-Reply-To: <c867145e-1440-bc88-f00d-d2323a05c8e2@sec.in.tum.de>



On 05/09/2017 08:17 AM, Sergej Proskurin wrote:
> Hi,
>
>>> What you currently do is try gva_to_ipa and if it does not work >> you will call p2m_gva_to_ipa. This sounds a bit pointless to me and
>>> waste of time if the underlying memory of stage-1 page table is >>
> protected. > > But we don't know that the stage-1 page table is
> protected until the > hardware based lookup fails. I can turn your
> argument around and say > doing the software based lookup is pointless
> and a waste of time > when the stage-1 table is not protected. Which is
> by the way what I > would expect to see in most cases.
>
> I agree with Tamas: I also believe that in most cases the stage-1
> translation table won't be protected. So, in my opinion, falling back to
> software (which will be presumablly a rare operation) is the better
> approach.

Well, you both consider that it is better to do the fallback by assuming 
the TLBs will always cache the intermediate translations (e.g VA -> IPA) 
and not only the full S1 -> S2 translation (e.g VA -> PA).

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-05-09  8:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-30 19:48 [RFC PATCH 0/4] arm/mem_access: Walk guest page tables in SW if mem_access is active Sergej Proskurin
2017-04-30 19:48 ` [RFC PATCH 1/4] arm/mem_access: Move TTBCR_SZ_MASK to processor.h Sergej Proskurin
2017-05-02 11:47   ` Julien Grall
2017-04-30 19:48 ` [RFC PATCH 2/4] arm/mem_access: Change value of TTBCR_SZ_MASK Sergej Proskurin
2017-05-02 11:56   ` Julien Grall
2017-05-02 12:01     ` Julien Grall
2017-05-08  6:40       ` Sergej Proskurin
2017-05-08 11:31         ` Julien Grall
2017-05-08  6:25     ` Sergej Proskurin
2017-04-30 19:48 ` [RFC PATCH 3/4] arm/mem_access: Add further TCR_EL1/TTBCR defines Sergej Proskurin
2017-05-02 12:01   ` Julien Grall
2017-04-30 19:48 ` [RFC PATCH 4/4] arm/mem_access: Add software guest-page-table walk Sergej Proskurin
2017-05-01 14:38   ` Razvan Cojocaru
2017-05-01 15:39     ` Sergej Proskurin
2017-05-02 15:17   ` Julien Grall
2017-05-08  9:22     ` Sergej Proskurin
2017-05-08 11:44       ` Julien Grall
2017-05-08 19:42         ` Tamas K Lengyel
2017-05-08 20:53           ` Julien Grall
2017-05-08 21:22             ` Tamas K Lengyel
2017-05-09  7:17           ` Sergej Proskurin
2017-05-09  8:09             ` Julien Grall [this message]
2017-05-09 16:04               ` Tamas K Lengyel
2017-05-09 16:22                 ` Julien Grall
2017-05-09 16:45                   ` Tamas K Lengyel
2017-05-09 18:55                     ` Julien Grall
2017-05-09 18:56                       ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6bf077c-d1a6-492c-9ad0-63e65f4c6ae9@arm.com \
    --to=julien.grall@arm.com \
    --cc=proskurin@sec.in.tum.de \
    --cc=rcojocaru@bitdefender.com \
    --cc=sstabellini@kernel.org \
    --cc=tamas@tklengyel.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).