Re: [PATCH v3 06/17] SUPPORT.md: Add scalability features

[George Dunlap <george.dunlap@citrix.com>]

On 11/23/2017 10:50 AM, Jan Beulich wrote:
>>>> On 22.11.17 at 20:20, <george.dunlap@citrix.com> wrote:
>> Superpage support and PVHVM.
>>
>> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> with one remark:
> 
>> +## Scalability
>> +
>> +### Super page support
>> +
>> +    Status, x86 HVM/PVH, HAP: Supported
>> +    Status, x86 HVM/PVH, Shadow, 2MiB: Supported
>> +    Status, ARM: Supported
>> +
>> +NB that this refers to the ability of guests
>> +to have higher-level page table entries point directly to memory,
>> +improving TLB performance.
>> +On ARM, and on x86 in HAP mode,
>> +the guest has whatever support is enabled by the hardware.
>> +On x86 in shadow mode, only 2MiB (L2) superpages are available;
>> +furthermore, they do not have the performance characteristics of hardware superpages.
>> +
>> +Also note is feature independent of the ARM "page granularity" feature (see below).
> 
> Earlier lines in this block suggest you've tried to honor a certain
> line length limit, while the two last non-empty ones clearly go
> beyond 80 columns.

Yes, the "semantic newlines" is a bit ambiguous: It rather implies that
we expect people to use a processed version of this file (in which case
the line length isn't as important).

But I'll trim these down anyway.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel