From: Andres Lagar-Cavilla <andres@lagarcavilla.org>
To: xen-devel@lists.xensource.com
Cc: andres@gridcentric.ca, tim@xen.org, olaf@aepfle.de, adin@gridcentric.ca
Subject: [PATCH 1 of 2] x86/mm: Allow a page in p2m_ram_paged_out state to be loaded
Date: Mon, 09 Jan 2012 16:41:26 -0500 [thread overview]
Message-ID: <f7c330d5b4b5c78155bd.1326145286@xdev.gridcentric.ca> (raw)
In-Reply-To: <patchbomb.1326145285@xdev.gridcentric.ca>
xen/arch/x86/mm/p2m.c | 15 +++++++++++----
1 files changed, 11 insertions(+), 4 deletions(-)
This removes the need for a page to be accessed in order to be pageable
again. A pager can now page-in pages at will with no need to map them
in a separate thread.
Signed-off-by: Andres Lagar-Cavilla <andres@lagarcavilla.org>
Acked-by: Tim Deegan <tim@xen.org>
diff -r 90f764bf02c3 -r f7c330d5b4b5 xen/arch/x86/mm/p2m.c
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -964,7 +964,7 @@ void p2m_mem_paging_populate(struct doma
int p2m_mem_paging_prep(struct domain *d, unsigned long gfn, uint64_t buffer)
{
struct page_info *page;
- p2m_type_t p2mt;
+ p2m_type_t p2mt, target_p2mt;
p2m_access_t a;
mfn_t mfn;
struct p2m_domain *p2m = p2m_get_hostp2m(d);
@@ -982,8 +982,8 @@ int p2m_mem_paging_prep(struct domain *d
mfn = p2m->get_entry(p2m, gfn, &p2mt, &a, p2m_query, NULL);
ret = -ENOENT;
- /* Allow only missing pages */
- if ( p2mt != p2m_ram_paging_in_start )
+ /* Allow missing pages */
+ if ( (p2mt != p2m_ram_paging_in_start) && (p2mt != p2m_ram_paged) )
goto out;
/* Allocate a page if the gfn does not have one yet */
@@ -1018,8 +1018,15 @@ int p2m_mem_paging_prep(struct domain *d
}
}
+ target_p2mt = (p2mt == p2m_ram_paging_in_start) ?
+ /* If we kicked the pager with a populate event, the pager will send
+ * a resume event back */
+ p2m_ram_paging_in :
+ /* If this was called asynchronously by the pager, then we can
+ * transition directly to the final guest-accessible type */
+ (paging_mode_log_dirty(d) ? p2m_ram_logdirty : p2m_ram_rw);
/* Fix p2m mapping */
- set_p2m_entry(p2m, gfn, mfn, PAGE_ORDER_4K, p2m_ram_paging_in, a);
+ set_p2m_entry(p2m, gfn, mfn, PAGE_ORDER_4K, target_p2mt, a);
atomic_dec(&d->paged_pages);
next prev parent reply other threads:[~2012-01-09 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 21:41 [PATCH 0 of 2] x86/mm: Two hypervisor paging fixes Andres Lagar-Cavilla
2012-01-09 21:41 ` Andres Lagar-Cavilla [this message]
2012-01-11 7:45 ` [PATCH 1 of 2] x86/mm: Allow a page in p2m_ram_paged_out state to be loaded Hongkaixing
2012-01-11 14:57 ` Andres Lagar-Cavilla
2012-01-12 2:24 ` Hongkaixing
2012-01-09 21:41 ` [PATCH 2 of 2] x86/mm: Disable paging_prep Andres Lagar-Cavilla
2012-01-12 10:57 ` [PATCH 0 of 2] x86/mm: Two hypervisor paging fixes Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7c330d5b4b5c78155bd.1326145286@xdev.gridcentric.ca \
--to=andres@lagarcavilla.org \
--cc=adin@gridcentric.ca \
--cc=andres@gridcentric.ca \
--cc=olaf@aepfle.de \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).