Re: [RFC v2 5/7] acpi:arm64: Add support for parsing IORT table

[Julien Grall <julien.grall@linaro.org>]

Hi Sameer,

On 11/15/2017 01:27 AM, Goel, Sameer wrote:
> 
> 
> On 11/8/2017 7:41 AM, Manish Jaggi wrote:
>> Hi Sameer
>>
>> On 9/21/2017 6:07 AM, Sameer Goel wrote:
>>> Add support for parsing IORT table to initialize SMMU devices.
>>> * The code for creating an SMMU device has been modified, so that the SMMU
>>> device can be initialized.
>>> * The NAMED NODE code has been commented out as this will need DOM0 kernel
>>> support.
>>> * ITS code has been included but it has not been tested.
>>>
>>> Signed-off-by: Sameer Goel <sgoel@codeaurora.org>
>> Followup of the discussions we had on iort parsing and querying streamID and deviceId based on RID.
>> I have extended your patchset with a patch that provides an alternative
>> way of parsing iort into maps : {rid-streamid}, {rid-deviceID)
>> which can directly be looked up for searching streamId for a rid. This
>> will remove the need to traverse iort table again.
>>
>> The test patch just describes the proposed flow and how the parsing and
>> query code might fit in. I have not tested it.
>> The code only compiles.
>>
>> https://github.com/mjaggi-cavium/xen-wip/commit/df006d64bdbb5c8344de5a710da8bf64c9e8edd5
>> (This repo has all 7 of your patches + test code patch merged.
>>
>> Note: The commit text of the patch describes the basic flow /assumptions / usage of functions.
>> Please see the code along with the v2 design draft.
>> [RFC] [Draft Design v2] ACPI/IORT Support in Xen.
>> https://lists.xen.org/archives/html/xen-devel/2017-11/msg00512.html
>>
>> I seek your advice on this. Please provide your feedback.
> I responded back on the other thread. I think we are fixing something that is not broken. I will try to post a couple of new RFCs and let's discuss this with incremental changes on the mailing list.

That other thread was a separate mailing list. For the benefits of the 
rest of the community it would be nice if you can post the summary here.

However, nobody said the code was broken. IORT will be used in various 
place in Xen and Manish is looking whether we can parse only once and 
for all the IORT. I think it is latest design is promising for that.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel