Re: [RFC] kbdif: add multi-touch support

[Oleksandr Andrushchenko <andr2000@gmail.com>]

On 01/03/2017 06:28 PM, Jan Beulich wrote:
>>>> On 03.01.17 at 16:39, <andr2000@gmail.com> wrote:
>> --- a/xen/include/public/io/kbdif.h
>> +++ b/xen/include/public/io/kbdif.h
>> @@ -45,6 +45,19 @@
>>    */
>>   #define XENKBD_TYPE_POS     4
>>   
>> +/*
>> + * Multi-touch event
>> + * Capable backend sets feature-multi-touch in xenstore.
>> + * Frontend requests feature by setting request-multi-touch in xenstore.
>> + * Frontend supports up to XENKBD_MT_NUM_DEV virtual multi-touch input devices,
>> + * configured by the backend in xenstore under mt-%d folder, %d being
>> + * a sequential number of the virtual input device:
>> + *   o num-contacts - number of simultaneous touches supported
>> + *   o width - width of the touch area in pixels
>> + *   o height - height of the touch area in pixels
>> + */
>> +#define XENKBD_TYPE_MTOUCH  5
>> +
>>   struct xenkbd_motion
>>   {
>>       uint8_t type;        /* XENKBD_TYPE_MOTION */
>> @@ -68,6 +81,56 @@ struct xenkbd_position
>>       int32_t rel_z;       /* relative Z motion (wheel) */
>>   };
>>   
>> +/* number of simultaneously supported multi-touch virtual input devices */
>> +#define XENKBD_MT_NUM_DEV   4
> Why is this limit needed? There's no use of it within the other
> interface additions you make.
>
> Jan
Well, the only reason for that was a shy attempt to somewhat simplify
changes to the existing frontend, e.g. handling fixed number of mt input
devices rather than allocating all those dynamically, finding the number
of devices configured at run-time etc.
I will happily remove this limitation though

Oleksandr


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel