From: Owen Smith <owen.smith@citrix.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Anthony Perard <anthony.perard@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"sstabellini@kernel.org" <sstabellini@kernel.org>
Subject: Re: [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers
Date: Tue, 13 Jun 2017 15:01:35 +0000 [thread overview]
Message-ID: <f8c381d8dd07408faaac1ebf014c8f46@AMSPEX02CL02.citrite.net> (raw)
In-Reply-To: <1496929152.29761.3.camel@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1123 bytes --]
Noted, I have had a look at porting the xenfb input handlers to the
qemu_input_handler_*() functions, and will post an update that combines patch
3 and 4 of this series.
From: Gerd Hoffmann<mailto:kraxel@redhat.com>
Sent: 08 June 2017 14:39
To: Owen Smith<mailto:owen.smith@citrix.com>; qemu-devel@nongnu.org<mailto:qemu-devel@nongnu.org>
Cc: sstabellini@kernel.org<mailto:sstabellini@kernel.org>; Anthony Perard<mailto:anthony.perard@citrix.com>; xen-devel@lists.xenproject.org<mailto:xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers
diff --git a/ui/input-legacy.c b/ui/input-legacy.c
> index 7159747..fbe1ce7 100644
> --- a/ui/input-legacy.c
> +++ b/ui/input-legacy.c
> @@ -142,6 +142,18 @@ QEMUPutKbdEntry
> *qemu_add_kbd_event_handler(QEMUPutKBDEvent *func, void *opaque)
> return entry;
> }
>
> +void qemu_activate_kbd_event_handler(QEMUPutKbdEntry *entry)
Please don't add new code to input-legacy.c please.
Switch your code to use the new qemu_input_handler_*() functions
directly instead.
cheers,
Gerd
[-- Attachment #1.2: Type: text/html, Size: 2656 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-06-13 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 13:15 [PATCH 0/4] xenfb: Add vkbd-only option Owen Smith
2017-06-08 13:15 ` [PATCH 1/4] xenfb: Add feature-vkbd-standalone Owen Smith
2017-06-08 22:31 ` Stefano Stabellini
2017-06-08 13:15 ` [PATCH 2/4] xenfb: Activate mouse handler Owen Smith
2017-06-08 22:33 ` Stefano Stabellini
2017-06-08 13:15 ` [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers Owen Smith
2017-06-08 13:39 ` Gerd Hoffmann
2017-06-13 15:01 ` Owen Smith [this message]
2017-06-08 13:15 ` [PATCH 4/4] xenfb: Fix leak by adding/removing keyboard handler Owen Smith
2017-06-08 22:24 ` [PATCH 0/4] xenfb: Add vkbd-only option Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8c381d8dd07408faaac1ebf014c8f46@AMSPEX02CL02.citrite.net \
--to=owen.smith@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).