From mboxrd@z Thu Jan 1 00:00:00 1970 From: Owen Smith Subject: Re: [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers Date: Tue, 13 Jun 2017 15:01:35 +0000 Message-ID: References: <1496927734-29174-1-git-send-email-owen.smith@citrix.com> <1496927734-29174-4-git-send-email-owen.smith@citrix.com>, <1496929152.29761.3.camel@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1730485591596713431==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKnLt-0001MQ-GI for xen-devel@lists.xenproject.org; Tue, 13 Jun 2017 15:03:29 +0000 In-Reply-To: <1496929152.29761.3.camel@redhat.com> Content-Language: en-GB List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Gerd Hoffmann , "qemu-devel@nongnu.org" Cc: Anthony Perard , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" List-Id: xen-devel@lists.xenproject.org --===============1730485591596713431== Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_f8c381d8dd07408faaac1ebf014c8f46AMSPEX02CL02citritenet_" --_000_f8c381d8dd07408faaac1ebf014c8f46AMSPEX02CL02citritenet_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Noted, I have had a look at porting the xenfb input handlers to the qemu_input_handler_*() functions, and will post an update that combines pat= ch 3 and 4 of this series. From: Gerd Hoffmann Sent: 08 June 2017 14:39 To: Owen Smith; qemu-devel@nongnu.org Cc: sstabellini@kernel.org; Anthony Perard; xen-devel@lists.xenproject.org Subject: Re: [PATCH 3/4] ui/input: Add activate/remove for keyboard handler= s diff --git a/ui/input-legacy.c b/ui/input-legacy.c > index 7159747..fbe1ce7 100644 > --- a/ui/input-legacy.c > +++ b/ui/input-legacy.c > @@ -142,6 +142,18 @@ QEMUPutKbdEntry > *qemu_add_kbd_event_handler(QEMUPutKBDEvent *func, void *opaque) > return entry; > } > > +void qemu_activate_kbd_event_handler(QEMUPutKbdEntry *entry) Please don't add new code to input-legacy.c please. Switch your code to use the new qemu_input_handler_*() functions directly instead. cheers, Gerd --_000_f8c381d8dd07408faaac1ebf014c8f46AMSPEX02CL02citritenet_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Noted, I have had a look at porting the xenfb inpu= t handlers to the

qemu_input_handler_*() functions, and will post an= update that combines patch

3 and 4 of this series.

 

From: Gerd Hoffmann
Sent: 08 June 2017 14:39
To: Owen Smith; qemu-devel@nongnu.org
Cc: sstabellini@kernel.org= ; Anthony Perard; xen-d= evel@lists.xenproject.org
Subject: Re: [PATCH 3/4] ui/input: Add activate/remove for keyboard = handlers

 

diff --git a/ui/input-legacy.c b/ui/input-legacy.c=
> index 7159747..fbe1ce7 100644
> --- a/ui/input-legacy.c
> +++ b/ui/input-legacy.c
> @@ -142,6 +142,18 @@ QEMUPutKbdEntry
> *qemu_add_kbd_event_handler(QEMUPutKBDEvent *func, void *opaque)
>      return entry;
>  }
>  
> +void qemu_activate_kbd_event_handler(QEMUPutKbdEntry *entry)

Please don't add new code to input-legacy.c please.

Switch your code to use the new qemu_input_handler_*() functions
directly instead.

cheers,
  Gerd
 --_000_f8c381d8dd07408faaac1ebf014c8f46AMSPEX02CL02citritenet_-- --===============1730485591596713431== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============1730485591596713431==--