From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 13 of 26] libxl:
	libxl_device_console.build_state is const
Date: Mon, 16 Aug 2010 15:33:37 +0100
Message-ID: <f8c43de0c6d661c1662c.1281969217@localhost.localdomain>
References: <patchbomb.1281969204@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <patchbomb.1281969204@localhost.localdomain>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1281969065 -3600
# Node ID f8c43de0c6d661c1662c8a34d5838b8755ae8fde
# Parent  5567b7c1b303d6f54d76a0efe63353701a12dad3
libxl: libxl_device_console.build_state is const

This field always refers to a libxl_domain_build_state structure which
is managed already by the caller, therefore it is incorrect to free it
as part of libxl_device_console_destroy.

(arguably this field should be a copy of, not a reference too, the original)

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

diff -r 5567b7c1b303 -r f8c43de0c6d6 tools/libxl/libxltypes.idl
--- a/tools/libxl/libxltypes.idl	Mon Aug 16 15:31:05 2010 +0100
+++ b/tools/libxl/libxltypes.idl	Mon Aug 16 15:31:05 2010 +0100
@@ -195,7 +195,7 @@ libxl_device_console = Struct("device_co
     ("domid", domid),
     ("devid", integer),
     ("consback", libxl_console_consback),
-    ("build_state", Reference(libxl_domain_build_state)),
+    ("build_state", Reference(libxl_domain_build_state), True),
     ("output", string),
     ])