From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xenproject.org
Cc: Kevin Tian <kevin.tian@intel.com>,
Jan Beulich <jbeulich@suse.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Jun Nakajima <jun.nakajima@intel.com>,
Brian Woods <brian.woods@amd.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH v2 01/23] x86: change name of parameter for various invlpg functions
Date: Tue, 4 Sep 2018 09:42:49 -0400 [thread overview]
Message-ID: <f933b8db-81ec-5b39-b686-dabfff1618cf@oracle.com> (raw)
In-Reply-To: <20180903134644.s6ddvd57eluw72pi@zion.uk.xensource.com>
On 09/03/2018 09:46 AM, Wei Liu wrote:
> On Sun, Aug 26, 2018 at 01:19:34PM +0100, Wei Liu wrote:
>> They all incorrectly named a parameter virtual address while it should
>> have been linear address.
>>
>> Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Is there more comment on this?
>
> These being rather mechanical changes makes me wonder if I should wait
> to collect all necessary ack/review or just go ahead with Jan and
> Kevin's.
As I said earlier, I am not convinced this change is necessary since AMD
defines virtual and linear addresses as synonyms (see, for example,
section 1.1.1. in volume 2).
However, if others think linear is a better term to use, that's fine too.
Acked-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-04 13:43 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-26 12:19 [PATCH v2 00/23] Make CONFIG_HVM work Wei Liu
2018-08-26 12:19 ` [PATCH v2 01/23] x86: change name of parameter for various invlpg functions Wei Liu
2018-08-27 13:49 ` Boris Ostrovsky
2018-08-27 13:54 ` Jan Beulich
2018-08-27 14:20 ` Jan Beulich
2018-08-30 1:26 ` Tian, Kevin
2018-09-03 13:46 ` Wei Liu
2018-09-04 13:42 ` Boris Ostrovsky [this message]
2018-08-26 12:19 ` [PATCH v2 02/23] xen: is_hvm_{domain, vcpu} should evaluate to false when !CONFIG_HVM Wei Liu
2018-08-27 14:24 ` Jan Beulich
2018-08-28 8:41 ` Wei Liu
2018-08-28 11:09 ` Julien Grall
2018-08-26 12:19 ` [PATCH v2 03/23] x86: enclose hvm_op and dm_op in CONFIG_HVM in relevant tables Wei Liu
2018-08-27 14:24 ` Jan Beulich
2018-08-26 12:19 ` [PATCH v2 04/23] x86/hvm: provide hvm_hap_supported Wei Liu
2018-08-27 14:25 ` Jan Beulich
2018-08-26 12:19 ` [PATCH v2 05/23] x86: provide stub for memory_type_changed Wei Liu
2018-08-27 14:28 ` Jan Beulich
2018-08-26 12:19 ` [PATCH v2 06/23] x86: don't call vpci function in physdev_op when !CONFIG_HAS_VPCI Wei Liu
2018-08-27 14:29 ` Jan Beulich
2018-08-28 8:45 ` Wei Liu
2018-08-28 9:08 ` Jan Beulich
2018-08-29 16:23 ` Wei Liu
2018-08-26 12:19 ` [PATCH v2 07/23] x86/vpmu: put HVM only code under CONFIG_HVM Wei Liu
2018-08-27 15:03 ` Jan Beulich
2018-08-26 12:19 ` [PATCH v2 08/23] xen/pt: io.c contains HVM only code Wei Liu
2018-08-27 15:04 ` Jan Beulich
2018-08-26 12:19 ` [PATCH v2 09/23] x86/pt: make it build with !CONFIG_HVM Wei Liu
2018-08-27 15:07 ` Jan Beulich
2018-08-30 1:29 ` Tian, Kevin
2018-08-26 12:19 ` [PATCH v2 10/23] x86/pt: split out HVM functions from vtd.c Wei Liu
2018-08-30 1:29 ` Tian, Kevin
2018-08-26 12:19 ` [PATCH v2 11/23] x86: XENMEM_resource_ioreq_server is HVM only Wei Liu
2018-08-27 15:13 ` Jan Beulich
2018-08-29 16:28 ` Wei Liu
2018-08-26 12:19 ` [PATCH v2 12/23] x86: monitor.o is currently " Wei Liu
2018-08-26 16:33 ` Razvan Cojocaru
2018-08-27 15:18 ` Jan Beulich
2018-08-27 15:23 ` Razvan Cojocaru
2018-08-29 16:42 ` Wei Liu
2018-08-29 17:43 ` Tamas K Lengyel
2018-08-29 18:09 ` Razvan Cojocaru
2018-08-30 7:14 ` Wei Liu
2018-08-26 12:19 ` [PATCH v2 13/23] x86: provide stubs, declarations and macros in hvm.h Wei Liu
2018-08-27 15:43 ` Jan Beulich
2018-09-03 9:45 ` Paul Durrant
2018-09-03 9:50 ` Wei Liu
2018-08-26 12:19 ` [PATCH v2 14/23] x86/mm: put nested p2m code under CONFIG_HVM Wei Liu
2018-08-27 15:56 ` Jan Beulich
2018-08-28 8:40 ` Wei Liu
2018-08-28 9:10 ` Jan Beulich
2018-08-26 12:19 ` [PATCH v2 15/23] x86/mm: put HVM only " Wei Liu
2018-08-26 16:39 ` Razvan Cojocaru
2018-08-27 9:03 ` Wei Liu
2018-08-28 10:41 ` Wei Liu
2018-08-28 10:53 ` Jan Beulich
2018-08-27 16:01 ` Jan Beulich
2018-08-28 10:41 ` Wei Liu
2018-08-26 12:19 ` [PATCH v2 16/23] x86/p2m/pod: make it build with !CONFIG_HVM Wei Liu
2018-08-28 10:47 ` Jan Beulich
2018-08-28 10:54 ` Wei Liu
2018-08-28 11:32 ` Jan Beulich
2018-08-26 12:19 ` [PATCH v2 17/23] x86/mm: put paging_update_nestedmode under CONFIG_HVM Wei Liu
2018-08-28 10:50 ` Jan Beulich
2018-08-30 7:42 ` Wei Liu
2018-08-30 8:35 ` Jan Beulich
2018-09-03 14:27 ` Wei Liu
2018-09-03 14:48 ` Jan Beulich
2018-08-26 12:19 ` [PATCH v2 18/23] x86/domctl: XEN_DOMCTL_debug_op is HVM only Wei Liu
2018-08-28 10:50 ` Jan Beulich
2018-08-26 12:19 ` [PATCH v2 19/23] x86: PIT emulation is common to both PV and HVM Wei Liu
2018-08-28 11:44 ` Jan Beulich
2018-08-28 13:19 ` Wei Liu
2018-08-28 14:36 ` Jan Beulich
2018-08-28 14:48 ` Wei Liu
2018-08-28 14:51 ` Andrew Cooper
2018-08-28 14:58 ` Wei Liu
2018-08-28 15:04 ` Jan Beulich
2018-08-28 15:17 ` Wei Liu
2018-08-28 14:56 ` Wei Liu
2018-08-26 12:19 ` [PATCH v2 20/23] xen: connect guest creation with CONFIG_{HVM, PV} Wei Liu
2018-08-28 11:07 ` Julien Grall
2018-08-28 13:13 ` Wei Liu
2018-08-28 11:47 ` Jan Beulich
2018-08-28 13:15 ` Wei Liu
2018-08-26 12:19 ` [PATCH v2 21/23] x86: expose CONFIG_HVM Wei Liu
2018-08-28 11:50 ` Jan Beulich
2018-08-28 12:14 ` Andrew Cooper
2018-08-28 13:33 ` Jan Beulich
2018-08-29 16:56 ` Andrew Cooper
2018-08-30 6:21 ` Jan Beulich
2018-08-30 6:57 ` Juergen Gross
2018-08-31 20:09 ` Andrew Cooper
2018-09-03 11:35 ` Jan Beulich
2018-08-26 12:19 ` [PATCH v2 22/23] x86/pvshim: disable HVM for PV shim Wei Liu
2018-08-26 12:19 ` [PATCH v2 23/23] xen: decouple HVM and IOMMU capabilities Wei Liu
2018-08-28 11:56 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f933b8db-81ec-5b39-b686-dabfff1618cf@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=brian.woods@amd.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).