From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
IanJackson <Ian.Jackson@eu.citrix.com>,
Jun Nakajima <jun.nakajima@intel.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 2/3] x86/HVM: support (emulate) UMIP
Date: Fri, 9 Dec 2016 18:42:51 +0000 [thread overview]
Message-ID: <f980a747-389f-d431-398c-d405854da99d@citrix.com> (raw)
In-Reply-To: <58495E090200007800126B8F@prv-mh.provo.novell.com>
On 08/12/16 12:20, Jan Beulich wrote:
>
>> However, it would also require only enabling the SVM GP intercept in the
>> hvm_update_guest_vendor() path (which should be renamed to something
>> slightly more generic like hvm_cpuid_policy_updated()).
> Why that? We always need it intercepted as long as the guest
> wants UMIP, but the hardware doesn't offer it. The feature isn't
> tied to the vendor being Intel or some such.
The hvm_update_guest_vendor() path is post-domain_create() way of
signalling "cpuid has changed - you might want to reconfigure intercepts".
It is currently used only to alter the #UD intercept based on the set
CPUID vendor (hence its name), but the name now looks rather short sighted.
With the proposal of having emulated-UMIP as explicitly opt-in, the
required intercepts shouldn't be enabled at domain_create() time, and
should be enabled later after the toolstack has set a policy.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-09 18:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 11:35 [PATCH 0/3] x86/HVM: misc improvements Jan Beulich
2016-12-06 11:43 ` [PATCH 1/3] x86/HVM: introduce hvm_get_cpl() and respective hook Jan Beulich
2016-12-06 12:16 ` Razvan Cojocaru
2016-12-06 13:49 ` Andrew Cooper
2016-12-06 14:07 ` Jan Beulich
2016-12-06 14:10 ` Andrew Cooper
2016-12-06 15:49 ` Boris Ostrovsky
2016-12-07 6:21 ` Tian, Kevin
2016-12-13 8:45 ` Ping: " Jan Beulich
2016-12-13 9:33 ` Tim Deegan
2016-12-06 11:44 ` [PATCH 2/3] x86/HVM: support (emulate) UMIP Jan Beulich
2016-12-06 14:47 ` Andrew Cooper
2016-12-06 14:55 ` Jan Beulich
2016-12-06 14:57 ` Andrew Cooper
2016-12-08 12:20 ` Jan Beulich
2016-12-09 18:42 ` Andrew Cooper [this message]
2016-12-06 16:23 ` Boris Ostrovsky
2016-12-07 11:29 ` Jan Beulich
2016-12-07 15:10 ` Boris Ostrovsky
2016-12-07 15:14 ` Jan Beulich
2016-12-07 15:31 ` Boris Ostrovsky
2016-12-07 15:39 ` Jan Beulich
2016-12-07 16:06 ` Andrew Cooper
2016-12-08 8:20 ` Tian, Kevin
2016-12-26 3:56 ` Suravee Suthikulpanit
2016-12-06 11:45 ` [PATCH 3/3] x86/HVM: prefer structure assignment for seg reg copying Jan Beulich
2016-12-06 11:47 ` Paul Durrant
2016-12-06 13:55 ` Andrew Cooper
2016-12-06 16:25 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f980a747-389f-d431-398c-d405854da99d@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).