From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: george.dunlap@eu.citrix.com
Subject: [PATCH] libxl: Handle non-ballooned, zero slackmem properly for pci passthru
Date: Tue, 27 Mar 2012 16:01:43 +0100 [thread overview]
Message-ID: <f9ce45c9f9842ce5d829.1332860503@kodo2> (raw)
The e820_sanitize() function in libxl_pci.c expects one of its arguments to
be non-zero; but since a recent changeset, it can typically expect *to be*
zero. Since the zero case is handled properly, just remove the check.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
diff -r d35a117afa2f -r f9ce45c9f984 tools/libxl/libxl_pci.c
--- a/tools/libxl/libxl_pci.c Tue Mar 27 15:25:07 2012 +0200
+++ b/tools/libxl/libxl_pci.c Tue Mar 27 16:01:21 2012 +0100
@@ -1177,7 +1177,7 @@ static int e820_sanitize(libxl_ctx *ctx,
uint32_t i, idx = 0, nr;
struct e820entry e820[E820MAX];
- if (!src || !map_limitkb || !balloon_kb || !nr_entries)
+ if (!src || !map_limitkb || !nr_entries)
return ERROR_INVAL;
nr = *nr_entries;
next reply other threads:[~2012-03-27 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 15:01 George Dunlap [this message]
2012-04-02 16:22 ` [PATCH] libxl: Handle non-ballooned, zero slackmem properly for pci passthru Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9ce45c9f9842ce5d829.1332860503@kodo2 \
--to=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).