* [PATCH] libxl: Handle non-ballooned, zero slackmem properly for pci passthru
@ 2012-03-27 15:01 George Dunlap
2012-04-02 16:22 ` Ian Jackson
0 siblings, 1 reply; 2+ messages in thread
From: George Dunlap @ 2012-03-27 15:01 UTC (permalink / raw)
To: xen-devel; +Cc: george.dunlap
The e820_sanitize() function in libxl_pci.c expects one of its arguments to
be non-zero; but since a recent changeset, it can typically expect *to be*
zero. Since the zero case is handled properly, just remove the check.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
diff -r d35a117afa2f -r f9ce45c9f984 tools/libxl/libxl_pci.c
--- a/tools/libxl/libxl_pci.c Tue Mar 27 15:25:07 2012 +0200
+++ b/tools/libxl/libxl_pci.c Tue Mar 27 16:01:21 2012 +0100
@@ -1177,7 +1177,7 @@ static int e820_sanitize(libxl_ctx *ctx,
uint32_t i, idx = 0, nr;
struct e820entry e820[E820MAX];
- if (!src || !map_limitkb || !balloon_kb || !nr_entries)
+ if (!src || !map_limitkb || !nr_entries)
return ERROR_INVAL;
nr = *nr_entries;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libxl: Handle non-ballooned, zero slackmem properly for pci passthru
2012-03-27 15:01 [PATCH] libxl: Handle non-ballooned, zero slackmem properly for pci passthru George Dunlap
@ 2012-04-02 16:22 ` Ian Jackson
0 siblings, 0 replies; 2+ messages in thread
From: Ian Jackson @ 2012-04-02 16:22 UTC (permalink / raw)
To: George Dunlap; +Cc: xen-devel
George Dunlap writes ("[Xen-devel] [PATCH] libxl: Handle non-ballooned, zero slackmem properly for pci passthru"):
> The e820_sanitize() function in libxl_pci.c expects one of its arguments to
> be non-zero; but since a recent changeset, it can typically expect *to be*
> zero. Since the zero case is handled properly, just remove the check.
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-02 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-27 15:01 [PATCH] libxl: Handle non-ballooned, zero slackmem properly for pci passthru George Dunlap
2012-04-02 16:22 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).