* [PATCH] python-libxl: Py_INCREF(Py_None) when returing Py_None
@ 2012-03-07 0:31 Marek Marczykowski
2012-03-13 17:20 ` Ian Jackson
0 siblings, 1 reply; 2+ messages in thread
From: Marek Marczykowski @ 2012-03-07 0:31 UTC (permalink / raw)
To: xen-devel; +Cc: marmarek
# HG changeset patch
# User Marek Marczykowski <marmarek@invisiblethingslab.com>
# Date 1331080262 -3600
# Node ID fbb9214867da594448499c0834f3f906f150f8c5
# Parent 8964c223836c2889364aa75cb1a662ff5eacd5d8
python-libxl: Py_INCREF(Py_None) when returing Py_None
Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
diff --git a/tools/python/xen/lowlevel/xl/xl.c b/tools/python/xen/lowlevel/xl/xl.c
--- a/tools/python/xen/lowlevel/xl/xl.c
+++ b/tools/python/xen/lowlevel/xl/xl.c
@@ -408,6 +408,8 @@ static PyObject *pyxl_domid_to_name(XlOb
domname = libxl_domid_to_name(self->ctx, domid);
if (domname)
ret = PyString_FromString(domname);
+ else
+ Py_INCREF(Py_None);
free(domname);
return ret;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] python-libxl: Py_INCREF(Py_None) when returing Py_None
2012-03-07 0:31 [PATCH] python-libxl: Py_INCREF(Py_None) when returing Py_None Marek Marczykowski
@ 2012-03-13 17:20 ` Ian Jackson
0 siblings, 0 replies; 2+ messages in thread
From: Ian Jackson @ 2012-03-13 17:20 UTC (permalink / raw)
To: Marek Marczykowski; +Cc: xen-devel
Marek Marczykowski writes ("[Xen-devel] [PATCH] python-libxl: Py_INCREF(Py_None) when returing Py_None"):
> python-libxl: Py_INCREF(Py_None) when returing Py_None
>
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
Thanks.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
Grumble. The Python people really do like making life difficult,
don't they ?
Ian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-13 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-07 0:31 [PATCH] python-libxl: Py_INCREF(Py_None) when returing Py_None Marek Marczykowski
2012-03-13 17:20 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).