From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 3/5] viridian: define type for the 'virtual VP assist page'
Date: Fri, 9 Nov 2018 10:31:03 +0000 [thread overview]
Message-ID: <fcf10e36fecf42619a2d11bd1661d58a@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <5BE5604802000078001FA17F@prv1-mh.provo.novell.com>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: 09 November 2018 10:24
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; xen-devel <xen-
> devel@lists.xenproject.org>
> Subject: Re: [PATCH v3 3/5] viridian: define type for the 'virtual VP
> assist page'
>
> >>> On 07.11.18 at 11:52, <paul.durrant@citrix.com> wrote:
> > --- a/xen/include/asm-x86/hvm/viridian.h
> > +++ b/xen/include/asm-x86/hvm/viridian.h
> > @@ -20,11 +20,13 @@ union viridian_page_msr
> > } fields;
> > };
> >
> > +typedef union _HV_VP_ASSIST_PAGE HV_VP_ASSIST_PAGE;
> > +
> > struct viridian_vcpu
> > {
> > struct {
> > union viridian_page_msr msr;
> > - void *va;
> > + HV_VP_ASSIST_PAGE *ptr;
> > bool pending;
> > } vp_assist;
> > uint64_t crash_param[5];
>
> I'll commit this as is, but even better would have been to avoid
> having the typedef here (visible to everyone).
>
It goes away in the next patch anyway, when the generalized guest_page is introduced.
Paul
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-09 10:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 10:52 [PATCH v3 0/5] (remainder of) viridian cleanup Paul Durrant
2018-11-07 10:52 ` [PATCH v3 1/5] viridian: separate interrupt related enlightenment implementations Paul Durrant
2018-11-07 11:36 ` Roger Pau Monné
2018-11-07 10:52 ` [PATCH v3 2/5] viridian: separate time " Paul Durrant
2018-11-07 11:43 ` Roger Pau Monné
2018-11-07 10:52 ` [PATCH v3 3/5] viridian: define type for the 'virtual VP assist page' Paul Durrant
2018-11-07 11:48 ` Roger Pau Monné
2018-11-07 11:50 ` Paul Durrant
2018-11-09 10:24 ` Jan Beulich
2018-11-09 10:31 ` Paul Durrant [this message]
2018-11-07 10:52 ` [PATCH v3 4/5] tools/misc: fix hard tabs in xen-hvmctx.c Paul Durrant
2018-11-07 13:08 ` Wei Liu
2018-11-07 13:09 ` Paul Durrant
2018-11-07 10:52 ` [PATCH v3 5/5] viridian: introduce struct viridian_page Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcf10e36fecf42619a2d11bd1661d58a@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).