From: Paolo Bonzini <pbonzini@redhat.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] hvmloader: always include HPET table
Date: Fri, 20 May 2011 09:04:55 +0200 [thread overview]
Message-ID: <fcf10fdad1e3c23bcbf0.1305874878@yakj.usersys.redhat.com> (raw)
# HG changeset patch
# User Paolo Bonzini <pbonzini@redhat.com>
# Date 1305874860 -7200
# Node ID fcf10fdad1e3c23bcbf0fbf119755970f9e38064
# Parent 8605c877b972c82a385915e38c0171952621ac3c
hvmloader: always include HPET table
Windows SVVP tests require an HPET table even if the HPET is disabled.
This makes sense since the HPET _is_ in the DSDT and, while the OS does
not know that, in principle it's status may change.
(For what it's worth SeaBIOS, in addition to doing this, totally ignores
QEMU's -no-hpet flag and always reports 0x0f for the HPET's _STA method).
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
diff --git a/tools/firmware/hvmloader/acpi/build.c b/tools/firmware/hvmloader/acpi/build.c
--- a/tools/firmware/hvmloader/acpi/build.c
+++ b/tools/firmware/hvmloader/acpi/build.c
@@ -190,12 +190,9 @@ static int construct_secondary_tables(ui
}
/* HPET. */
- if ( hpet_exists(ACPI_HPET_ADDRESS) )
- {
- hpet = (struct acpi_20_hpet *)&buf[offset];
- offset += construct_hpet(hpet);
- table_ptrs[nr_tables++] = (unsigned long)hpet;
- }
+ hpet = (struct acpi_20_hpet *)&buf[offset];
+ offset += construct_hpet(hpet);
+ table_ptrs[nr_tables++] = (unsigned long)hpet;
if ( battery_port_exists() )
{
reply other threads:[~2011-05-20 7:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcf10fdad1e3c23bcbf0.1305874878@yakj.usersys.redhat.com \
--to=pbonzini@redhat.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).