From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: [PATCH] hvmloader: always include HPET table Date: Fri, 20 May 2011 09:04:55 +0200 Message-ID: Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org # HG changeset patch # User Paolo Bonzini # Date 1305874860 -7200 # Node ID fcf10fdad1e3c23bcbf0fbf119755970f9e38064 # Parent 8605c877b972c82a385915e38c0171952621ac3c hvmloader: always include HPET table Windows SVVP tests require an HPET table even if the HPET is disabled. This makes sense since the HPET _is_ in the DSDT and, while the OS does not know that, in principle it's status may change. (For what it's worth SeaBIOS, in addition to doing this, totally ignores QEMU's -no-hpet flag and always reports 0x0f for the HPET's _STA method). Signed-off-by: Paolo Bonzini diff --git a/tools/firmware/hvmloader/acpi/build.c b/tools/firmware/hvmloader/acpi/build.c --- a/tools/firmware/hvmloader/acpi/build.c +++ b/tools/firmware/hvmloader/acpi/build.c @@ -190,12 +190,9 @@ static int construct_secondary_tables(ui } /* HPET. */ - if ( hpet_exists(ACPI_HPET_ADDRESS) ) - { - hpet = (struct acpi_20_hpet *)&buf[offset]; - offset += construct_hpet(hpet); - table_ptrs[nr_tables++] = (unsigned long)hpet; - } + hpet = (struct acpi_20_hpet *)&buf[offset]; + offset += construct_hpet(hpet); + table_ptrs[nr_tables++] = (unsigned long)hpet; if ( battery_port_exists() ) {