From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: david.westwood@hpe.com, Andrew Cooper <andrew.cooper3@citrix.com>,
Srinivas REDDY Eeda <srinivas.eeda@oracle.com>,
Xen-Devel <xen-devel@lists.xen.org>,
manoj.gopalasetty@hpe.com
Subject: Re: [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar()
Date: Thu, 16 Aug 2018 17:30:58 +0800 [thread overview]
Message-ID: <fdcad3f9-df8f-7242-b8e2-7447a153b7ad@oracle.com> (raw)
In-Reply-To: <670ef321-52e8-e501-faf9-a91e0ce94013@oracle.com>
On 2018/8/16 17:13, Zhenzhong Duan wrote:
>>
>>> --- a/xen/arch/x86/setup.c
>>> +++ b/xen/arch/x86/setup.c
>>> @@ -1493,6 +1493,10 @@ void __init noreturn __start_xen(unsigned long
>>> mbi_p)
>>> generic_apic_probe();
>>> + pt_pci_init();
>>> +
>>> + acpi_mmcfg_init();
>>> +
>>> acpi_boot_init();
>>
>> With the dependency being _in_ acpi_boot_init(), the invocation of
>> acpi_mmcfg_init() should now be moved there.
> Yes, I feel better to move pt_pci_init() and acpi_mmcfg_init() in
> acpi_boot_init() before acpi_mmcfg_init(). Any more comments?
I see acpi_boot_init() is empty func when CONFIG_ACPI_BOOT isn't set. Do
we support disabling this config option? If yes, I think above change
will break non-acpi case.
Thanks
Zhenzhong
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-16 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 5:10 [PATCH] x86/mmcfg/drhd: Move acpi_mmcfg_init() before calling acpi_parse_dmar() Zhenzhong Duan
2018-08-16 7:10 ` Jan Beulich
2018-08-16 9:13 ` Zhenzhong Duan
2018-08-16 9:30 ` Zhenzhong Duan [this message]
2018-08-16 10:42 ` Jan Beulich
2018-08-16 23:50 ` Zhenzhong Duan
2018-08-16 10:37 ` Jan Beulich
2018-08-17 0:12 ` Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdcad3f9-df8f-7242-b8e2-7447a153b7ad@oracle.com \
--to=zhenzhong.duan@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=david.westwood@hpe.com \
--cc=manoj.gopalasetty@hpe.com \
--cc=srinivas.eeda@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).