From: George Dunlap <george.dunlap@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v2 08/10] libxl: fix coding style of credit1 parameters related functions
Date: Fri, 30 Sep 2016 14:25:43 +0100 [thread overview]
Message-ID: <fdf067a7-a847-9a17-9f4a-e9e249b79b05@citrix.com> (raw)
In-Reply-To: <1475237087.5315.74.camel@citrix.com>
On 30/09/16 13:04, Dario Faggioli wrote:
> On Fri, 2016-09-30 at 11:24 +0100, Ian Jackson wrote:
>> Dario Faggioli writes ("[PATCH v2 08/10] libxl: fix coding style of
>> credit1 parameters related functions"):
>>> int libxl_sched_credit_params_set(libxl_ctx *ctx, uint32_t poolid,
>>> libxl_sched_credit_params
>>> *scinfo)
>>> {
>>> struct xen_sysctl_credit_schedule sparam;
>>> - int rc=0;
>>> + int r, rc;
>> ...
>>>
>>>
>>> scinfo->tslice_ms = sparam.tslice_ms;
>>> scinfo->ratelimit_us = sparam.ratelimit_us;
>>>
>>> + out:
>>> GC_FREE;
>>> - return 0;
>>> + return rc;
>>
>> I think this is missing an assignment
>>
>> rc = 0;
>>
>> on the successful exit path, just before out. Am I wrong ?
>>
> Indeed it's missing. It was not necessary in v1 of this patch, so I
> must have failed to notice that it was, when splitting that in two.
>
> Sorry.
>
> Not sure how to proceed, so I'm attaching an updated version of the
> patch to this email.
I've fixed it up in my tree, and added your Acked-by, Ian.
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-30 13:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 2:53 [PATCH v2 00/10] sched: Credit1 and Credit2 improvements... but *NO* soft-affinity for Credit2! Dario Faggioli
2016-09-30 2:53 ` [PATCH v2 01/10] xen: credit1: return the 'time remaining to the limit' as next timeslice Dario Faggioli
2016-09-30 11:16 ` George Dunlap
2016-09-30 2:53 ` [PATCH v2 02/10] xen: credit1: don't rate limit context switches in case of yields Dario Faggioli
2016-09-30 11:18 ` George Dunlap
2016-09-30 2:53 ` [PATCH v2 03/10] xen: credit2: make tickling more deterministic Dario Faggioli
2016-09-30 11:25 ` George Dunlap
2016-09-30 2:53 ` [PATCH v2 04/10] xen: credit2: only reset credit on reset condition Dario Faggioli
2016-09-30 11:28 ` George Dunlap
2016-09-30 12:25 ` anshul makkar
2016-09-30 12:57 ` Dario Faggioli
2016-09-30 2:53 ` [PATCH v2 05/10] xen: credit2: implement yield() Dario Faggioli
2016-09-30 12:52 ` George Dunlap
2016-09-30 14:01 ` Dario Faggioli
2016-09-30 2:54 ` [PATCH v2 06/10] xen: tracing: add trace records for schedule and rate-limiting Dario Faggioli
2016-09-30 13:16 ` George Dunlap
2016-10-01 0:18 ` Meng Xu
2016-09-30 2:54 ` [PATCH v2 07/10] tools: tracing: handle more scheduling related events Dario Faggioli
2016-09-30 10:22 ` Ian Jackson
2016-09-30 2:54 ` [PATCH v2 08/10] libxl: fix coding style of credit1 parameters related functions Dario Faggioli
2016-09-30 10:24 ` Ian Jackson
2016-09-30 12:04 ` Dario Faggioli
2016-09-30 13:25 ` George Dunlap [this message]
2016-09-30 2:54 ` [PATCH v2 09/10] libxl: allow to set the ratelimit value online for Credit2 Dario Faggioli
2016-09-30 10:30 ` Ian Jackson
2016-09-30 10:33 ` George Dunlap
2016-09-30 10:35 ` Ian Jackson
2016-09-30 12:37 ` Dario Faggioli
2016-09-30 2:54 ` [PATCH v2 10/10] xl: " Dario Faggioli
2016-09-30 10:34 ` Ian Jackson
2016-09-30 15:54 ` Dario Faggioli
2016-09-30 16:02 ` Ian Jackson
2016-10-13 22:19 ` Jim Fehlig
2016-10-14 11:31 ` George Dunlap
2016-09-30 13:51 ` [PATCH v2 00/10] sched: Credit1 and Credit2 improvements... but *NO* soft-affinity for Credit2! George Dunlap
2016-09-30 14:06 ` Dario Faggioli
2016-09-30 14:10 ` George Dunlap
2016-09-30 14:12 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdf067a7-a847-9a17-9f4a-e9e249b79b05@citrix.com \
--to=george.dunlap@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).