[PATCH 1/2] xen/Kconfig: Drop redundant comments from Kconfig files

[PATCH 1/2] xen/Kconfig: Drop redundant comments from Kconfig files

[Andrew Cooper]

Most of the comments are duplicated from the help text, and those without help
provide no useful additional input.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Doug Goldstein <cardoe@cardoe.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>
---
 xen/arch/arm/Kconfig            |  3 ---
 xen/common/Kconfig              | 14 --------------
 xen/drivers/acpi/Kconfig        |  1 -
 xen/drivers/char/Kconfig        |  7 -------
 xen/drivers/cpufreq/Kconfig     |  1 -
 xen/drivers/passthrough/Kconfig |  1 -
 xen/drivers/pci/Kconfig         |  1 -
 xen/drivers/video/Kconfig       |  3 ---
 8 files changed, 31 deletions(-)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 871c243..797c91f 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -1,4 +1,3 @@
-# Select 32 or 64 bit
 config 64BIT
 	bool
 	default ARCH != "arm32"
@@ -43,11 +42,9 @@ config ACPI
 	  Advanced Configuration and Power Interface (ACPI) support for Xen is
 	  an alternative to device tree on ARM64.
 
-# Select HAS_GICV3 if GICv3 is supported
 config HAS_GICV3
 	bool
 
-# Select ALTERNATIVE if the architecture supports runtime patching
 config ALTERNATIVE
 	bool
 
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index befa30e..b2d3d61 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -11,31 +11,24 @@ config COMPAT
 config CORE_PARKING
 	bool
 
-# Select HAS_DEVICE_TREE if device tree is supported
 config HAS_DEVICE_TREE
 	bool
 
-# Select HAS_MEM_ACCESS if mem access is supported
 config HAS_MEM_ACCESS
 	bool
 
-# Select HAS_MEM_PAGING if mem paging is supported
 config HAS_MEM_PAGING
 	bool
 
-# Select HAS_MEM_SHARING if mem sharing is supported
 config HAS_MEM_SHARING
 	bool
 
-# Select HAS_PDX if PDX is supported
 config HAS_PDX
 	bool
 
-# Select HAS_KEXEC if kexec is supported
 config HAS_KEXEC
 	bool
 
-# Select HAS_GDBSX if GDBSX is supported
 config HAS_GDBSX
 	bool
 
@@ -50,7 +43,6 @@ config HAS_CHECKPOLICY
 	string
 	option env="XEN_HAS_CHECKPOLICY"
 
-# Enable/Disable kexec support
 config KEXEC
 	bool "kexec support"
 	default y
@@ -62,7 +54,6 @@ config KEXEC
 
 	  If unsure, say Y.
 
-# Allows "late" initialization of the hardware domain
 config LATE_HWDOM
 	bool "dedicated hardware domain"
 	default n
@@ -83,7 +74,6 @@ config LATE_HWDOM
 
 	  If unsure, say N.
 
-# Enables transcendent memory support
 config TMEM
 	def_bool y
 	prompt "Transcendent Memory Support" if EXPERT = "y"
@@ -97,7 +87,6 @@ config TMEM
 
 	  If unsure, say Y.
 
-# Adds support for Xenoprof
 config XENOPROF
 	def_bool y
 	prompt "Xen Oprofile Support" if EXPERT = "y"
@@ -110,7 +99,6 @@ config XENOPROF
 
 	  If unsure, say Y.
 
-# Enable/Disable XSM support
 config XSM
 	bool "Xen Security Modules support"
 	default n
@@ -163,7 +151,6 @@ config XSM_POLICY
 
 	  If unsure, say Y.
 
-# Enable schedulers
 menu "Schedulers"
 	visible if EXPERT = "y"
 
@@ -221,7 +208,6 @@ endmenu
 config CRYPTO
 	bool
 
-# Enable/Disable live patching support
 config LIVEPATCH
 	bool "Live patching support (TECH PREVIEW)"
 	default n
diff --git a/xen/drivers/acpi/Kconfig b/xen/drivers/acpi/Kconfig
index 1074dbf..b64d373 100644
--- a/xen/drivers/acpi/Kconfig
+++ b/xen/drivers/acpi/Kconfig
@@ -1,5 +1,4 @@
 
-# Select ACPI if ACPI is supported
 config ACPI
 	bool
 
diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index 08973cf..51343d0 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -1,11 +1,9 @@
-#  16550-series UART support
 config HAS_NS16550
 	bool
 	default y
 	help
 	  This selects the 16550-series UART support. For most systems, say Y.
 
-# Xilinx Zynq Cadence UART support
 config HAS_CADENCE_UART
 	bool
 	default y
@@ -14,7 +12,6 @@ config HAS_CADENCE_UART
 	  This selects the Xilinx Zynq Cadence UART. If you have a Xilinx Zynq
 	  based board, say Y.
 
-# ARM AMBA PL011 UART support
 config HAS_PL011
 	bool
 	default y
@@ -23,7 +20,6 @@ config HAS_PL011
 	  This selects the ARM(R) AMBA(R) PrimeCell PL011 UART. If you have
 	  an Integrator/PP2, Integrator/CP or Versatile platform, say Y.
 
-# Samsung Exynos 4210 UART support
 config HAS_EXYNOS4210
 	bool
 	default y
@@ -32,7 +28,6 @@ config HAS_EXYNOS4210
 	  This selects the Samsung Exynos 4210 UART. If you have a Samsung
 	  Exynos based board, say Y.
 
-# OMAP UART support
 config HAS_OMAP
 	bool
 	default y
@@ -41,7 +36,6 @@ config HAS_OMAP
 	  This selects the Texas Instruments OMAP UART. If you have a Texas
 	  Instruments based CPU, say Y.
 
-# SuperH SCI(F) UART support
 config HAS_SCIF
 	bool
 	default y
@@ -50,7 +44,6 @@ config HAS_SCIF
 	  This selects the SuperH SCI(F) UART. If you have a SuperH based board,
 	  say Y.
 
-# USB EHCI debug port support
 config HAS_EHCI
 	bool
 	help
diff --git a/xen/drivers/cpufreq/Kconfig b/xen/drivers/cpufreq/Kconfig
index 00be480..cce80f4 100644
--- a/xen/drivers/cpufreq/Kconfig
+++ b/xen/drivers/cpufreq/Kconfig
@@ -1,4 +1,3 @@
 
-# Select HAS_CPUFREQ if CPU frequency scaling is supported
 config HAS_CPUFREQ
 	bool
diff --git a/xen/drivers/passthrough/Kconfig b/xen/drivers/passthrough/Kconfig
index 05a8daf..8d90b67 100644
--- a/xen/drivers/passthrough/Kconfig
+++ b/xen/drivers/passthrough/Kconfig
@@ -1,4 +1,3 @@
 
-# Select HAS_PASSTHROUGH if device pass through is supported
 config HAS_PASSTHROUGH
 	bool
diff --git a/xen/drivers/pci/Kconfig b/xen/drivers/pci/Kconfig
index 68b9953..7da03fa 100644
--- a/xen/drivers/pci/Kconfig
+++ b/xen/drivers/pci/Kconfig
@@ -1,4 +1,3 @@
 
-# Select HAS_PCI if PCI is supported
 config HAS_PCI
 	bool
diff --git a/xen/drivers/video/Kconfig b/xen/drivers/video/Kconfig
index 739fe6f..0ffbbd9 100644
--- a/xen/drivers/video/Kconfig
+++ b/xen/drivers/video/Kconfig
@@ -1,13 +1,10 @@
 
-# Select VIDEO if video is supported
 config VIDEO
 	bool
 
-# Select VGA if VGA is supported
 config VGA
 	bool
 	select VIDEO
 
-# Select HAS_ARM_HDLCD if ARM HDLCD is supported
 config HAS_ARM_HDLCD
 	bool
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[PATCH 2/2] xen/Kconfig: Misc tweaks

[Andrew Cooper]

 * Drop one piece of trailing whitespace
 * Reposition LATE_HWDOM so it sits properly nested inside XSM in menuconfig
 * Spelling and grammar corrections

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Doug Goldstein <cardoe@cardoe.com>
CC: Jan Beulich <JBeulich@suse.com>
---
 xen/common/Kconfig | 44 ++++++++++++++++++++++----------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index b2d3d61..92d4610 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -54,26 +54,6 @@ config KEXEC
 
 	  If unsure, say Y.
 
-config LATE_HWDOM
-	bool "dedicated hardware domain"
-	default n
-	depends on XSM && X86
-	---help---
-	  Allows the creation of a dedicated hardware domain distinct from
-	  domain 0 that manages devices without needing access to other
-	  privileged functionality such as the ability to manage domains.
-	  This requires that the actual domain 0 be a stub domain that
-	  constructs the actual hardware domain instead of initializing the
-	  hardware itself.  Because the hardware domain needs access to
-	  hypercalls not available to unprivileged guests, an XSM policy
-	  is required to properly define the privilege of these domains.
-
-	  This feature does nothing if the "hardware_dom" boot parameter is
-	  not present.  If this feature is being used for security, it should
-	  be combined with an IOMMU in strict mode.
-
-	  If unsure, say N.
-
 config TMEM
 	def_bool y
 	prompt "Transcendent Memory Support" if EXPERT = "y"
@@ -141,7 +121,7 @@ config XSM_POLICY
 	depends on XSM
 	---help---
 	  This includes a default XSM policy in the hypervisor so that the
-	  bootloader does not need to load a policy to get sane behavior from an
+	  bootloader does not need to load a policy to get sane behaviour from an
 	  XSM-enabled hypervisor.  If this is disabled, a policy must be
 	  provided by the bootloader or by Domain 0.  Even if this is enabled, a
 	  policy provided by the bootloader will override it.
@@ -151,6 +131,26 @@ config XSM_POLICY
 
 	  If unsure, say Y.
 
+config LATE_HWDOM
+	bool "Dedicated hardware domain"
+	default n
+	depends on XSM && X86
+	---help---
+	  Allows the creation of a dedicated hardware domain distinct from
+	  domain 0 that manages devices without needing access to other
+	  privileged functionality such as the ability to manage domains.
+	  This requires that the actual domain 0 be a stub domain that
+	  constructs the actual hardware domain instead of initializing the
+	  hardware itself.  Because the hardware domain needs access to
+	  hypercalls not available to unprivileged guests, an XSM policy
+	  is required to properly define the privilege of these domains.
+
+	  This feature does nothing if the "hardware_dom" boot parameter is
+	  not present.  If this feature is being used for security, it should
+	  be combined with an IOMMU in strict mode.
+
+	  If unsure, say N.
+
 menu "Schedulers"
 	visible if EXPERT = "y"
 
@@ -183,7 +183,7 @@ config SCHED_ARINC653
 
 choice
 	prompt "Default Scheduler?"
-	default SCHED_CREDIT_DEFAULT 
+	default SCHED_CREDIT_DEFAULT
 
 	config SCHED_CREDIT_DEFAULT
 		bool "Credit Scheduler" if SCHED_CREDIT
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/2] xen/Kconfig: Drop redundant comments from Kconfig files

[Jan Beulich]

>>> On 19.08.16 at 17:54, <andrew.cooper3@citrix.com> wrote:
> Most of the comments are duplicated from the help text, and those without help
> provide no useful additional input.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Non-ARM parts
Acked-by: Jan Beulich <jbeulich@suse.com>

albeit being known to rather comment too little I think that shouldn't
be taken to count too much, i.e. waiting for some further one would
probably not be a bad idea.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 2/2] xen/Kconfig: Misc tweaks

[Jan Beulich]

 >>> On 19.08.16 at 17:54, <andrew.cooper3@citrix.com> wrote:
> * Drop one piece of trailing whitespace
>  * Reposition LATE_HWDOM so it sits properly nested inside XSM in menuconfig
>  * Spelling and grammar corrections
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
with one question:

> @@ -141,7 +121,7 @@ config XSM_POLICY
>  	depends on XSM
>  	---help---
>  	  This includes a default XSM policy in the hypervisor so that the
> -	  bootloader does not need to load a policy to get sane behavior from an
> +	  bootloader does not need to load a policy to get sane behaviour from an

Isn't the original spelling valid in American English?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 2/2] xen/Kconfig: Misc tweaks

[Doug Goldstein]

[-- Attachment #1.1.1: Type: text/plain, Size: 1011 bytes --]

On 8/19/16 11:14 AM, Jan Beulich wrote:
>  >>> On 19.08.16 at 17:54, <andrew.cooper3@citrix.com> wrote:
>> * Drop one piece of trailing whitespace
>>  * Reposition LATE_HWDOM so it sits properly nested inside XSM in menuconfig
>>  * Spelling and grammar corrections
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> with one question:
> 
>> @@ -141,7 +121,7 @@ config XSM_POLICY
>>  	depends on XSM
>>  	---help---
>>  	  This includes a default XSM policy in the hypervisor so that the
>> -	  bootloader does not need to load a policy to get sane behavior from an
>> +	  bootloader does not need to load a policy to get sane behaviour from an
> 
> Isn't the original spelling valid in American English?
> 
> Jan
> 

Yes. An American English speaker wrote it originally as well. Spelling
and grammatical changes to what I write are always welcome.

Reviewed-by: Doug Goldstein <cardoe@cardoe.com>

-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 2/2] xen/Kconfig: Misc tweaks

[Andrew Cooper]

On 19/08/16 17:50, Doug Goldstein wrote:
> On 8/19/16 11:14 AM, Jan Beulich wrote:
>>  >>> On 19.08.16 at 17:54, <andrew.cooper3@citrix.com> wrote:
>>> * Drop one piece of trailing whitespace
>>>  * Reposition LATE_HWDOM so it sits properly nested inside XSM in menuconfig
>>>  * Spelling and grammar corrections
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>> with one question:
>>
>>> @@ -141,7 +121,7 @@ config XSM_POLICY
>>>  	depends on XSM
>>>  	---help---
>>>  	  This includes a default XSM policy in the hypervisor so that the
>>> -	  bootloader does not need to load a policy to get sane behavior from an
>>> +	  bootloader does not need to load a policy to get sane behaviour from an
>> Isn't the original spelling valid in American English?

Oh - so it is.

I will drop this correction.  I already did for a lot of s/z (mis)use.

~Andrew

>>
>> Jan
>>
> Yes. An American English speaker wrote it originally as well. Spelling
> and grammatical changes to what I write are always welcome.
>
> Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/2] xen/Kconfig: Drop redundant comments from Kconfig files

[Julien Grall]

Hi,

On 19/08/16 16:54, Andrew Cooper wrote:
> Most of the comments are duplicated from the help text, and those without help
> provide no useful additional input.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Doug Goldstein <cardoe@cardoe.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>

For ARM bits:

Acked-by: Julien Grall <julien.grall@arm.com>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH 1/2] xen/Kconfig: Drop redundant comments from Kconfig files

[Doug Goldstein]

[-- Attachment #1.1.1: Type: text/plain, Size: 488 bytes --]

On 8/19/16 11:54 AM, Andrew Cooper wrote:
> Most of the comments are duplicated from the help text, and those without help
> provide no useful additional input.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Doug Goldstein <cardoe@cardoe.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>

Reviewed-by: Doug Goldstein <cardoe@cardoe.com>


-- 
Doug Goldstein


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel