From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 12 of 32] tools: libxl: do not specify protocol node for disk or net
Date: Wed, 20 Apr 2011 17:15:31 +0100 [thread overview]
Message-ID: <fe29a8881d30e5da198d.1303316131@cosworth.uk.xensource.com> (raw)
In-Reply-To: <patchbomb.1303316119@cosworth.uk.xensource.com>
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1303315987 -3600
# Node ID fe29a8881d30e5da198d191af2a79abf9fcb25bf
# Parent d1a40e34829e71efe8819eead493a2243806efe5
tools: libxl: do not specify protocol node for disk or net
This node is written by the front/backends as part of their negotiation about
how to speak to each other. The toolstack has no part in this and it certainly
shouldn't be hardcoding the 32 bit protocol!
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r d1a40e34829e -r fe29a8881d30 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c Wed Apr 20 17:13:07 2011 +0100
+++ b/tools/libxl/libxl.c Wed Apr 20 17:13:07 2011 +0100
@@ -1060,11 +1060,6 @@ int libxl_device_disk_add(libxl_ctx *ctx
flexarray_append(front, "device-type");
flexarray_append(front, disk->is_cdrom ? "cdrom" : "disk");
- if (0 /* protocol != native*/) {
- flexarray_append(front, "protocol");
- flexarray_append(front, "x86_32-abi"); /* hardcoded ! */
- }
-
libxl__device_generic_add(&gc, &device,
libxl__xs_kvs_of_flexarray(&gc, back, back->count),
libxl__xs_kvs_of_flexarray(&gc, front, front->count));
@@ -1304,11 +1299,6 @@ int libxl_device_nic_add(libxl_ctx *ctx,
flexarray_append(front, libxl__sprintf(&gc, "%02x:%02x:%02x:%02x:%02x:%02x",
nic->mac[0], nic->mac[1], nic->mac[2],
nic->mac[3], nic->mac[4], nic->mac[5]));
- if (0 /* protocol != native*/) {
- flexarray_append(front, "protocol");
- flexarray_append(front, "x86_32-abi"); /* hardcoded ! */
- }
-
libxl__device_generic_add(&gc, &device,
libxl__xs_kvs_of_flexarray(&gc, back, back->count),
libxl__xs_kvs_of_flexarray(&gc, front, front->count));
next prev parent reply other threads:[~2011-04-20 16:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 16:15 [PATCH 00 of 32] [V2] tools: libxl IDL, SeaBIOS, ocaml binding autogeneration, misc Ian Campbell
2011-04-20 16:15 ` [PATCH 01 of 32] tools: libxl: hide selection of hvmloader by default Ian Campbell
2011-04-20 16:15 ` [PATCH 02 of 32] tools: libxl: hide selection of device-model " Ian Campbell
2011-04-20 16:15 ` [PATCH 03 of 32] tools: libxl: write selected BIOS to xenstore Ian Campbell
2011-04-20 16:15 ` [PATCH 04 of 32] tools: support SeaBIOS. Use by default when upstream qemu is configured Ian Campbell
2011-04-20 16:15 ` [PATCH 05 of 32] tools: libxl: move all enum values into the libxl namespace Ian Campbell
2011-04-20 16:15 ` [PATCH 06 of 32] tools: libxl: generalize libxl_qemu_machine_type into libxl_domain_type Ian Campbell
2011-04-20 16:15 ` [PATCH 07 of 32] tools: libxl: namespace enum values within their type Ian Campbell
2011-04-20 16:15 ` [PATCH 08 of 32] tools: libxl: add an Enumeration type to the IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 09 of 32] tools: libxl: add libxl_domid to IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 10 of 32] tools: libxl: remove BitField type class from IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 11 of 32] tools: libxl: add concept of in- and out-put only data types to IDL Ian Campbell
2011-04-20 16:15 ` Ian Campbell [this message]
2011-04-20 16:15 ` [PATCH 13 of 32] tools: ocaml: rename the device_nic types and functions Ian Campbell
2011-04-20 16:15 ` [PATCH 14 of 32] tools: ocaml: rename the disk_info " Ian Campbell
2011-04-20 16:15 ` [PATCH 15 of 32] tools: ocaml: rename the console " Ian Campbell
2011-04-20 16:15 ` [PATCH 16 of 32] tools: ocaml: rename the vkb " Ian Campbell
2011-04-20 16:15 ` [PATCH 17 of 32] tools: ocaml: rename the pci " Ian Campbell
2011-04-20 16:15 ` [PATCH 18 of 32] tools: ocaml: remove the domain_make and domain_build functions since they don't work Ian Campbell
2011-04-20 16:15 ` [PATCH 19 of 32] tools: ocaml: rename the create_info types and functions Ian Campbell
2011-04-20 16:15 ` [PATCH 20 of 32] tools: ocaml: rename the build_info " Ian Campbell
2011-04-20 16:15 ` [PATCH 21 of 32] tools: ocaml: rename the domain_build_state " Ian Campbell
2011-04-20 16:15 ` [PATCH 22 of 32] tools: ocaml: rename the physinfo " Ian Campbell
2011-04-20 16:15 ` [PATCH 23 of 32] tools: ocaml: rename the sched_credit " Ian Campbell
2011-04-20 16:15 ` [PATCH 24 of 32] tools: ocaml: rename the topology " Ian Campbell
2011-04-20 16:15 ` [PATCH 25 of 32] tools: libxl: remove libxl_domain_build_state from the IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 26 of 32] tools: libxl: remove Reference meta-type from IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 27 of 32] tools: libxl: reduce number of integer types in the IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 28 of 32] tools: ocaml: reorder xl bindings type and function definitions to match IDL Ian Campbell
2011-04-20 16:15 ` [PATCH 29 of 32] tools: ocaml: remove create_info and build_info data types from xl bindings Ian Campbell
2011-04-20 16:15 ` [PATCH 30 of 32] tools: ocaml: tweak whitespace in preparation for autogenerating " Ian Campbell
2011-04-20 16:15 ` [PATCH 31 of 32] tools: ocaml: lay ground work for auto generating xl datatypes Ian Campbell
2011-04-20 16:15 ` [PATCH 32 of 32] tools: ocaml: autogenerate xl datatype definitions and ocaml<->C conversion Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2011-04-18 13:53 [PATCH 00 of 32] tools: libxl IDL, SeaBIOS, ocaml binding autogeneration, misc Ian Campbell
2011-04-18 13:53 ` [PATCH 12 of 32] tools: libxl: do not specify protocol node for disk or net Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe29a8881d30e5da198d.1303316131@cosworth.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).