xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Anoob Soman <anoob.soman@citrix.com>
Cc: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/5] tools/firmware: Build ipxe as a standalone ROM
Date: Fri, 16 Mar 2018 11:21:55 +0000	[thread overview]
Message-ID: <fe392fc8-725b-0627-e03b-426b4b8bd799@citrix.com> (raw)
In-Reply-To: <5AABB61502000078001B2B11@prv-mh.provo.novell.com>

On 16/03/18 11:18, Jan Beulich wrote:
>
>> @@ -113,6 +114,11 @@ endif
>>  
>>  	mv $@.new $@
>>  
>> +ifneq ($(ETHERBOOT_ROMS),)
>> +$(ETHERBOOT_ROM): $(ETHERBOOT_ROMS)
>> +	cat $^ > $@
>> +endif
> I don't understand this: How can the bare concatenation of multiple
> binary blobs produce anything usable? How will the consumer know
> where the boundaries are, and which one is which?

These details are all covered in the option ROM/PnP metadata.  See
scan_etherboot_nic()/scan_option_rom() in hvmloader.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-03-16 11:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 17:31 Make iPXE a standalone ROM Anoob Soman
2018-03-15 17:31 ` [PATCH 1/5] tools/firmware: Build ipxe as " Anoob Soman
2018-03-16 11:18   ` Jan Beulich
2018-03-16 11:21     ` Andrew Cooper [this message]
2018-03-18  1:30     ` Doug Goldstein
2018-03-19  7:48       ` Jan Beulich
2018-03-19 13:52         ` Doug Goldstein
2018-03-15 17:31 ` [PATCH 2/5] tools/firmware: #define IPXE_PATH Anoob Soman
2018-03-21 15:18   ` Wei Liu
2018-03-26 15:53     ` Anoob Soman
2018-03-15 17:31 ` [PATCH 3/5] libxc: Allow loading of firmware modules for HVM guest Anoob Soman
2018-03-18  1:32   ` Doug Goldstein
2018-03-19 14:31     ` Anoob Soman
2018-03-21 15:17   ` Wei Liu
2018-03-26 15:51     ` Anoob Soman
2018-03-15 17:31 ` [PATCH 4/5] libxl: Load iPXE ROM from a file Anoob Soman
2018-03-18  1:34   ` Doug Goldstein
2018-03-21 15:25   ` Wei Liu
2018-03-26 15:51     ` Anoob Soman
2018-03-15 17:31 ` [PATCH 5/5] hvmloader: Use iPXE ROM loaded from a standalone file Anoob Soman
2018-03-16 11:26   ` Jan Beulich
2018-03-16 11:44     ` Andrew Cooper
2018-03-17 16:54       ` Doug Goldstein
2018-03-19 14:24     ` Anoob Soman
2018-03-19 15:21       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe392fc8-725b-0627-e03b-426b4b8bd799@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=anoob.soman@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).