From: "Yu, Zhang" <yu.c.zhang@linux.intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
xen-devel@lists.xen.org, Paul Durrant <paul.durrant@citrix.com>,
zhiyuan.lv@intel.com
Subject: Re: [PATCH for 4.7] Remove HVMMEM_mmio_write_dm from the public interface.
Date: Thu, 28 Apr 2016 20:57:55 +0800 [thread overview]
Message-ID: <fe9b3e28-4fa8-7569-8779-2ec9796a2bff@linux.intel.com> (raw)
In-Reply-To: <572220BF02000078000E6D9B@prv-mh.provo.novell.com>
On 4/28/2016 8:39 PM, Jan Beulich wrote:
>>>> On 28.04.16 at 14:12, <yu.c.zhang@linux.intel.com> wrote:
>> I'm still confused why do we need this, especially at such critical
>> moment. IIUC HVMMEM type is used to get/set mem type, why would someone
>> define a HVMMEM type but not use it here?
>
> Who knows. And as said - the patch can go in as is, I just inquired
> because I like to avoid future code churn whenever possible, i.e.
> when a certain way of coding makes it less likely for the code
> needing touching again compared to some other variant, I'd
> generally like that to be used (as long as it's not meaningfully worse
> in other respects).
>
Thanks Jan.
So my understanding is that this patch does not need any change any
more.
As to your concern, I still do not have any better thought.
And this hole is a problem because of the old mistake I have made in
previous version. Could we be careful in the future review to avoid
another hole(besides the HVMMEM_unused one which is unavoidable with
HVMMEM_ioreq_server), and if this can not be avoided, we try to find a
more graceful solution by then? :)
> Jan
>
>
Yu
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-28 12:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 8:29 [PATCH for 4.7] Remove HVMMEM_mmio_write_dm from the public interface Yu Zhang
2016-04-28 9:30 ` Paul Durrant
2016-04-28 10:22 ` Jan Beulich
2016-04-28 10:41 ` Paul Durrant
2016-04-28 10:42 ` George Dunlap
2016-04-28 10:57 ` Jan Beulich
2016-04-28 11:40 ` Yu, Zhang
2016-04-28 11:52 ` Jan Beulich
2016-04-28 12:00 ` Yu, Zhang
2016-04-28 12:31 ` Jan Beulich
2016-04-28 11:59 ` Wei Liu
2016-04-28 12:00 ` Andrew Cooper
2016-04-28 12:06 ` Wei Liu
2016-04-28 12:12 ` Yu, Zhang
2016-04-28 12:39 ` Jan Beulich
2016-04-28 12:57 ` Yu, Zhang [this message]
2016-04-28 12:34 ` Jan Beulich
2016-04-28 12:46 ` Wei Liu
2016-04-28 10:43 ` George Dunlap
2016-04-28 10:47 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe9b3e28-4fa8-7569-8779-2ec9796a2bff@linux.intel.com \
--to=yu.c.zhang@linux.intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).