From: Paul Durrant <Paul.Durrant@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.com>,
xen-devel <xen-devel@lists.xen.org>
Cc: "zhangchen.fnst@cn.fujitsu.com" <zhangchen.fnst@cn.fujitsu.com>
Subject: Re: ioreq server regression
Date: Mon, 12 Dec 2016 16:33:59 +0000 [thread overview]
Message-ID: <fecd0aab5dcb45ce9b3e13f52ea2ba51@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: 8c30c32d-6afc-6434-8b95-1a82e1e78dd9@citrix.com
> -----Original Message-----
> From: Paul Durrant
> Sent: 12 December 2016 16:29
> To: Andrew Cooper <Andrew.Cooper3@citrix.com>; Boris Ostrovsky
> <boris.ostrovsky@oracle.com>; Jan Beulich <jbeulich@suse.com>; Juergen
> Gross <jgross@suse.com>; xen-devel <xen-devel@lists.xen.org>
> Cc: zhangchen.fnst@cn.fujitsu.com
> Subject: RE: ioreq server regression
>
> > -----Original Message-----
> > From: Andrew Cooper
> > Sent: 12 December 2016 16:27
> > To: Paul Durrant <Paul.Durrant@citrix.com>; Boris Ostrovsky
> > <boris.ostrovsky@oracle.com>; Jan Beulich <jbeulich@suse.com>; Juergen
> > Gross <jgross@suse.com>; xen-devel <xen-devel@lists.xen.org>
> > Cc: zhangchen.fnst@cn.fujitsu.com
> > Subject: Re: ioreq server regression
> >
> > On 12/12/16 16:22, Paul Durrant wrote:
> > >> -----Original Message-----
> > >> From: Boris Ostrovsky [mailto:boris.ostrovsky@oracle.com]
> > >> Sent: 12 December 2016 16:02
> > >> To: Paul Durrant <Paul.Durrant@citrix.com>; Jan Beulich
> > >> <jbeulich@suse.com>; Andrew Cooper <Andrew.Cooper3@citrix.com>;
> > >> Juergen Gross <jgross@suse.com>; xen-devel <xen-
> devel@lists.xen.org>
> > >> Cc: zhangchen.fnst@cn.fujitsu.com
> > >> Subject: ioreq server regression
> > >>
> > >> Looks like commit e7dabe59c ("x86/hvm: don't unconditionally create a
> > >> default ioreq server") breaks restore for HVM guests.
> > >>
> > >> I see "qemu: hardware error: Invalid ioreq type 0x53" in qemu log.
> > >>
> > > Damn, yes that will be the case when migrating with legacy QEMU...
> we're
> > going to need another flag that's set on the domain by the restore code so
> > that the default server also gets created on restore.
> >
> > I don't understand why the existing code doesn't suffice. A domain
> > being restored is conceptually no different from one which is still
> > being constructed.
> >
> > The creation_finished flag should still be clear at this point during
> > restore.
>
> That's the problem... The creation flag is clear so reading the HVM params
> does not instantiate the default ioreq server in the target domain.
>
Sorry, ignore me... I my logic backwards.
I guess the creation flag must get set too early on restore.
Paul
> Paul
>
> > Is it perhaps something else doing a pause/unpause on the
> > domain before qemu starts up? The creation_finished flag should only be
> > set at the first point the refcount goes to zero, not the first unpause
> > hypercall.
> >
> > ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-12 16:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 16:01 ioreq server regression Boris Ostrovsky
2016-12-12 16:21 ` Jan Beulich
2016-12-12 16:28 ` Boris Ostrovsky
2016-12-12 16:22 ` Paul Durrant
2016-12-12 16:27 ` Andrew Cooper
2016-12-12 16:28 ` Paul Durrant
2016-12-12 16:33 ` Paul Durrant [this message]
2016-12-12 16:36 ` Andrew Cooper
2016-12-12 18:03 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fecd0aab5dcb45ce9b3e13f52ea2ba51@AMSPEX02CL03.citrite.net \
--to=paul.durrant@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xen.org \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).