From: Shriram Rajagopalan <rshriram@cs.ubc.ca>
To: xen-devel@lists.xensource.com
Subject: [PATCH] remus: fix incorrect error handling for switch_qemu_logdirty in checkpoint code
Date: Mon, 11 Apr 2011 10:58:56 -0700 [thread overview]
Message-ID: <fefe3359ab726e634c00.1302544736@athos.nss.cs.ubc.ca> (raw)
# HG changeset patch
# User Shriram Rajagopalan <rshriram@cs.ubc.ca>
# Date 1302544427 25200
# Node ID fefe3359ab726e634c00704eadeacfcf30b70c07
# Parent 697ac895c11c6d5d82524de56796cee98fded2a5
remus: fix incorrect error handling for switch_qemu_logdirty in checkpoint code
c/s 22275: "tools: cleanup domain save switch_qemu_logdirty callback"
introduced a whole bunch of error code fixups. In the process, it also ended up
treating the success return code (0) from switch_qemu_logdirty as an error and
vice versa.
Signed-off-by: Shriram Rajagopalan <rshriram@cs.ubc.ca>
diff -r 697ac895c11c -r fefe3359ab72 tools/python/xen/lowlevel/checkpoint/libcheckpoint.c
--- a/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c Sat Apr 09 12:42:24 2011 +0100
+++ b/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c Mon Apr 11 10:53:47 2011 -0700
@@ -185,7 +185,7 @@
hvm = s->domtype > dt_pv;
if (hvm) {
flags |= XCFLAGS_HVM;
- if (!switch_qemu_logdirty(s, 1))
+ if (switch_qemu_logdirty(s, 1))
return -1;
}
reply other threads:[~2011-04-11 17:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fefe3359ab726e634c00.1302544736@athos.nss.cs.ubc.ca \
--to=rshriram@cs.ubc.ca \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).