From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shriram Rajagopalan Subject: [PATCH] remus: fix incorrect error handling for switch_qemu_logdirty in checkpoint code Date: Mon, 11 Apr 2011 10:58:56 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org # HG changeset patch # User Shriram Rajagopalan # Date 1302544427 25200 # Node ID fefe3359ab726e634c00704eadeacfcf30b70c07 # Parent 697ac895c11c6d5d82524de56796cee98fded2a5 remus: fix incorrect error handling for switch_qemu_logdirty in checkpoint code c/s 22275: "tools: cleanup domain save switch_qemu_logdirty callback" introduced a whole bunch of error code fixups. In the process, it also ended up treating the success return code (0) from switch_qemu_logdirty as an error and vice versa. Signed-off-by: Shriram Rajagopalan diff -r 697ac895c11c -r fefe3359ab72 tools/python/xen/lowlevel/checkpoint/libcheckpoint.c --- a/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c Sat Apr 09 12:42:24 2011 +0100 +++ b/tools/python/xen/lowlevel/checkpoint/libcheckpoint.c Mon Apr 11 10:53:47 2011 -0700 @@ -185,7 +185,7 @@ hvm = s->domtype > dt_pv; if (hvm) { flags |= XCFLAGS_HVM; - if (!switch_qemu_logdirty(s, 1)) + if (switch_qemu_logdirty(s, 1)) return -1; }