From: Julien Grall <julien.grall@arm.com>
To: Manish Jaggi <mjaggi@caviumnetworks.com>,
Julien Grall <julien.grall@linaro.org>,
xen-devel@lists.xen.org, marc.zyngier@arm.com,
sstabellini@kernel.org, andre.przywara@linaro.org
Cc: manish.jaggi@cavium.com
Subject: Re: [RFC PATCH 01/10] Add CONFIG_VGIC_ERRATA
Date: Wed, 21 Feb 2018 15:56:53 +0000 [thread overview]
Message-ID: <ff095f05-c10f-19e5-361e-f6fbeb18ac2d@arm.com> (raw)
In-Reply-To: <a5be8c57-91cb-ed4d-915d-8bb1dd3df74b@caviumnetworks.com>
On 21/02/18 15:17, Manish Jaggi wrote:
> Hi Julien,
>
>
> On 01/25/2018 07:18 PM, Julien Grall wrote:
>> Hi Manish,
>>
>> On 16/01/18 15:42, mjaggi@caviumnetworks.com wrote:
>>> From: Manish Jaggi <manish.jaggi@cavium.com>
>>>
>>> Add a config option to enable VGIC Errata Code in Xen. Platforms
>>> which do not
>>> have this errta can compile out this feature.
>>
>> s/errta/errata/
>>
>>>
>>> Signed-off-by: Manish Jaggi <manish.jaggi@cavium.com>
>>> ---
>>> xen/arch/arm/Kconfig | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
>>> index f58019d6ed..2966e3a3d3 100644
>>> --- a/xen/arch/arm/Kconfig
>>> +++ b/xen/arch/arm/Kconfig
>>> @@ -59,6 +59,15 @@ config SBSA_VUART_CONSOLE
>>> endmenu
>>> +menu "Errata Workarounds"
>>> + depends on ARM_64
>>
>> I would much prefer to see the memu "ARM errata workaround via..."
>> renamed to "Errata Workarounds". So we have only one menu with all
>> workarounds.
> I am not sure it would work as
> menu "ARM errata workaround via the alternative framework"
> depends on HAS_ALTERNATIVE
>
> which may not be correct for vGIC errata.
vGIC errata are likely going to be based on alternative. So the call to
the function could be avoided on non-affected platform.
But as alternative is supported unconditionally by both Arm64 and Arm32,
this depends could just be dropped.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-21 15:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 15:42 [RFC PATCH 00/10] arm64: Mediate access to GICv3 sysregs at EL2 mjaggi
2018-01-16 15:42 ` [RFC PATCH 01/10] Add CONFIG_VGIC_ERRATA mjaggi
2018-01-25 13:48 ` Julien Grall
2018-02-21 15:17 ` Manish Jaggi
2018-02-21 15:56 ` Julien Grall [this message]
2018-01-16 15:42 ` [RFC PATCH 02/10] arm64: Add hook to handle guest GICv3 sysreg accesses mjaggi
2018-01-25 16:17 ` Julien Grall
2018-01-25 18:07 ` Julien Grall
2018-02-01 8:51 ` Manish Jaggi
2018-02-01 10:54 ` Julien Grall
2018-02-26 6:42 ` Manish Jaggi
2018-02-26 6:58 ` Manish Jaggi
2018-02-26 10:43 ` Julien Grall
2018-01-16 15:42 ` [PATCH 03/10] arm64: Add ICV_BPR1_EL1 handler mjaggi
2018-01-25 16:44 ` Julien Grall
2018-02-01 8:57 ` Manish Jaggi
2018-02-01 10:55 ` Julien Grall
2018-01-16 15:42 ` [PATCH 04/10] arm64: Add ICV_IGRPEN1_EL1 handler mjaggi
2018-01-16 15:43 ` [PATCH 05/10] arm64: Add accessors for the ICH_APxRn_EL2 registers mjaggi
2018-01-16 15:43 ` [PATCH 06/10] Expose gicv3_ich_read/write_lr mjaggi
2018-01-25 16:52 ` Julien Grall
2018-02-01 8:54 ` Manish Jaggi
2018-01-16 15:43 ` [PATCH 07/10] arm64: Add ICV_IAR1_EL1 handler mjaggi
2018-01-16 15:43 ` [PATCH 08/10] Add ICV_EOIR1_EL1 handler mjaggi
2018-01-16 15:43 ` [PATCH 09/10] arm64: Add a handler for ICV_HPPIR1_EL1 mjaggi
2018-01-16 15:43 ` [PATCH 10/10] Enable Trapping of Group1 registers which is controlled by command line mjaggi
2018-01-25 17:00 ` Julien Grall
2018-02-01 8:53 ` Manish Jaggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff095f05-c10f-19e5-361e-f6fbeb18ac2d@arm.com \
--to=julien.grall@arm.com \
--cc=andre.przywara@linaro.org \
--cc=julien.grall@linaro.org \
--cc=manish.jaggi@cavium.com \
--cc=marc.zyngier@arm.com \
--cc=mjaggi@caviumnetworks.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).