From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [RFC Patch v4 1/8] ioreq: remove most 'buf' parameter from static functions Date: Wed, 6 Dec 2017 14:44:52 +0000 Message-ID: References: <1512546614-9937-1-git-send-email-chao.gao@intel.com> <1512546614-9937-2-git-send-email-chao.gao@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1512546614-9937-2-git-send-email-chao.gao@intel.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: 'Chao Gao' , "xen-devel@lists.xen.org" Cc: Andrew Cooper , Jan Beulich List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IENoYW8gR2FvIFttYWlsdG86Y2hh by5nYW9AaW50ZWwuY29tXQo+IFNlbnQ6IDA2IERlY2VtYmVyIDIwMTcgMDc6NTAKPiBUbzogeGVu LWRldmVsQGxpc3RzLnhlbi5vcmcKPiBDYzogQ2hhbyBHYW8gPGNoYW8uZ2FvQGludGVsLmNvbT47 IEFuZHJldyBDb29wZXIKPiA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT47IEphbiBCZXVsaWNo IDxqYmV1bGljaEBzdXNlLmNvbT47IFBhdWwKPiBEdXJyYW50IDxQYXVsLkR1cnJhbnRAY2l0cml4 LmNvbT4KPiBTdWJqZWN0OiBbUkZDIFBhdGNoIHY0IDEvOF0gaW9yZXE6IHJlbW92ZSBtb3N0ICdi dWYnIHBhcmFtZXRlciBmcm9tIHN0YXRpYwo+IGZ1bmN0aW9ucwo+IAo+IEl0IGlzIGEgcHJlcGFy YXRpb24gdG8gc3VwcG9ydCBtdWx0aXBsZSBJT1JFUSBwYWdlcy4KPiBObyBmdW5jdGlvbmFsIGNo YW5nZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaGFvIEdhbyA8Y2hhby5nYW9AaW50ZWwuY29tPgo+ IC0tLQo+IHY0Ogo+ICAtbmV3Cj4gLS0tCj4gIHhlbi9hcmNoL3g4Ni9odm0vaW9yZXEuYyB8IDQ4 ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCj4gLS0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMjMgaW5zZXJ0aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vaW9yZXEuYyBiL3hlbi9hcmNoL3g4Ni9odm0vaW9y ZXEuYwo+IGluZGV4IGQ5OTFhYzkuLmE4NzlmMjAgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2 L2h2bS9pb3JlcS5jCj4gKysrIGIveGVuL2FyY2gveDg2L2h2bS9pb3JlcS5jCj4gQEAgLTIzNywx MCArMjM3LDkgQEAgc3RhdGljIHZvaWQgaHZtX2ZyZWVfaW9yZXFfZ2ZuKHN0cnVjdAo+IGh2bV9p b3JlcV9zZXJ2ZXIgKnMsIGdmbl90IGdmbikKPiAgICAgIHNldF9iaXQoaSwgJmQtPmFyY2guaHZt X2RvbWFpbi5pb3JlcV9nZm4ubWFzayk7Cj4gIH0KPiAKPiAtc3RhdGljIHZvaWQgaHZtX3VubWFw X2lvcmVxX2dmbihzdHJ1Y3QgaHZtX2lvcmVxX3NlcnZlciAqcywgYm9vbCBidWYpCj4gK3N0YXRp YyB2b2lkIGh2bV91bm1hcF9pb3JlcV9nZm4oc3RydWN0IGh2bV9pb3JlcV9zZXJ2ZXIgKnMsCj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGh2bV9pb3JlcV9wYWdlICpp b3JwKQo+ICB7Cj4gLSAgICBzdHJ1Y3QgaHZtX2lvcmVxX3BhZ2UgKmlvcnAgPSBidWYgPyAmcy0+ YnVmaW9yZXEgOiAmcy0+aW9yZXE7Cj4gLQoKSSBkb24ndCByZWFsbHkgbGlrZSB0aGlzIGFwcHJv YWNoLiBJJ2QgcHJlZmVyIHN3YXBwaW5nIHRoZSBib29sIGZvciBhbiB1bnNpZ25lZCBwYWdlIGlu ZGV4LCB3aGVyZSB3ZSBmb2xsb3cgdGhlIGNvbnZlbnRpb24gYWRvcHRlZCBpbiBodm1fZ2V0X2lv cmVxX3NlcnZlcl9mcmFtZSgpIGZvciB3aGljaCBtYWNyb3MgZXhpc3Q6IDAgZXF1YXRpbmcgdG8g dGhlIGJ1ZmlvcmVxIHBhZ2UsIDErIGZvciB0aGUgc3RydWN0LXBlci1jcHUgcGFnZXMuCgogIFBh dWwKCj4gICAgICBpZiAoIGdmbl9lcShpb3JwLT5nZm4sIElOVkFMSURfR0ZOKSApCj4gICAgICAg ICAgcmV0dXJuOwo+IAo+IEBAIC0yODksMTUgKzI4OCwxNSBAQCBzdGF0aWMgaW50IGh2bV9tYXBf aW9yZXFfZ2ZuKHN0cnVjdAo+IGh2bV9pb3JlcV9zZXJ2ZXIgKnMsIGJvb2wgYnVmKQo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmaW9ycC0+dmEpOwo+IAo+ICAgICAgaWYgKCBy YyApCj4gLSAgICAgICAgaHZtX3VubWFwX2lvcmVxX2dmbihzLCBidWYpOwo+ICsgICAgICAgIGh2 bV91bm1hcF9pb3JlcV9nZm4ocywgaW9ycCk7Cj4gCj4gICAgICByZXR1cm4gcmM7Cj4gIH0KPiAK PiAtc3RhdGljIGludCBodm1fYWxsb2NfaW9yZXFfbWZuKHN0cnVjdCBodm1faW9yZXFfc2VydmVy ICpzLCBib29sIGJ1ZikKPiArc3RhdGljIGludCBodm1fYWxsb2NfaW9yZXFfbWZuKHN0cnVjdCBo dm1faW9yZXFfc2VydmVyICpzLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3Ry dWN0IGh2bV9pb3JlcV9wYWdlICppb3JwKQo+ICB7Cj4gICAgICBzdHJ1Y3QgZG9tYWluICpjdXJy ZCA9IGN1cnJlbnQtPmRvbWFpbjsKPiAtICAgIHN0cnVjdCBodm1faW9yZXFfcGFnZSAqaW9ycCA9 IGJ1ZiA/ICZzLT5idWZpb3JlcSA6ICZzLT5pb3JlcTsKPiAKPiAgICAgIGlmICggaW9ycC0+cGFn ZSApCj4gICAgICB7Cj4gQEAgLTM0NCwxMCArMzQzLDkgQEAgc3RhdGljIGludCBodm1fYWxsb2Nf aW9yZXFfbWZuKHN0cnVjdAo+IGh2bV9pb3JlcV9zZXJ2ZXIgKnMsIGJvb2wgYnVmKQo+ICAgICAg cmV0dXJuIDA7Cj4gIH0KPiAKPiAtc3RhdGljIHZvaWQgaHZtX2ZyZWVfaW9yZXFfbWZuKHN0cnVj dCBodm1faW9yZXFfc2VydmVyICpzLCBib29sIGJ1ZikKPiArc3RhdGljIHZvaWQgaHZtX2ZyZWVf aW9yZXFfbWZuKHN0cnVjdCBodm1faW9yZXFfc2VydmVyICpzLAo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgc3RydWN0IGh2bV9pb3JlcV9wYWdlICppb3JwKQo+ICB7Cj4gLSAgICBz dHJ1Y3QgaHZtX2lvcmVxX3BhZ2UgKmlvcnAgPSBidWYgPyAmcy0+YnVmaW9yZXEgOiAmcy0+aW9y ZXE7Cj4gLQo+ICAgICAgaWYgKCAhaW9ycC0+cGFnZSApCj4gICAgICAgICAgcmV0dXJuOwo+IAo+ IEBAIC0zODAsMTEgKzM3OCwxMSBAQCBib29sIGlzX2lvcmVxX3NlcnZlcl9wYWdlKHN0cnVjdCBk b21haW4gKmQsIGNvbnN0Cj4gc3RydWN0IHBhZ2VfaW5mbyAqcGFnZSkKPiAgICAgIHJldHVybiBm b3VuZDsKPiAgfQo+IAo+IC1zdGF0aWMgdm9pZCBodm1fcmVtb3ZlX2lvcmVxX2dmbihzdHJ1Y3Qg aHZtX2lvcmVxX3NlcnZlciAqcywgYm9vbCBidWYpCj4gK3N0YXRpYyB2b2lkIGh2bV9yZW1vdmVf aW9yZXFfZ2ZuKHN0cnVjdCBodm1faW9yZXFfc2VydmVyICpzLAo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzdHJ1Y3QgaHZtX2lvcmVxX3BhZ2UgKmlvcnApCj4gCj4gIHsKPiAg ICAgIHN0cnVjdCBkb21haW4gKmQgPSBzLT5kb21haW47Cj4gLSAgICBzdHJ1Y3QgaHZtX2lvcmVx X3BhZ2UgKmlvcnAgPSBidWYgPyAmcy0+YnVmaW9yZXEgOiAmcy0+aW9yZXE7Cj4gCj4gICAgICBp ZiAoIElTX0RFRkFVTFQocykgfHwgZ2ZuX2VxKGlvcnAtPmdmbiwgSU5WQUxJRF9HRk4pICkKPiAg ICAgICAgICByZXR1cm47Cj4gQEAgLTM5NSwxMCArMzkzLDEwIEBAIHN0YXRpYyB2b2lkIGh2bV9y ZW1vdmVfaW9yZXFfZ2ZuKHN0cnVjdAo+IGh2bV9pb3JlcV9zZXJ2ZXIgKnMsIGJvb2wgYnVmKQo+ ICAgICAgY2xlYXJfcGFnZShpb3JwLT52YSk7Cj4gIH0KPiAKPiAtc3RhdGljIGludCBodm1fYWRk X2lvcmVxX2dmbihzdHJ1Y3QgaHZtX2lvcmVxX3NlcnZlciAqcywgYm9vbCBidWYpCj4gK3N0YXRp YyBpbnQgaHZtX2FkZF9pb3JlcV9nZm4oc3RydWN0IGh2bV9pb3JlcV9zZXJ2ZXIgKnMsCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGh2bV9pb3JlcV9wYWdlICppb3JwKQo+ ICB7Cj4gICAgICBzdHJ1Y3QgZG9tYWluICpkID0gcy0+ZG9tYWluOwo+IC0gICAgc3RydWN0IGh2 bV9pb3JlcV9wYWdlICppb3JwID0gYnVmID8gJnMtPmJ1ZmlvcmVxIDogJnMtPmlvcmVxOwo+ICAg ICAgaW50IHJjOwo+IAo+ICAgICAgaWYgKCBJU19ERUZBVUxUKHMpIHx8IGdmbl9lcShpb3JwLT5n Zm4sIElOVkFMSURfR0ZOKSApCj4gQEAgLTU1MCwzNiArNTQ4LDM2IEBAIHN0YXRpYyBpbnQgaHZt X2lvcmVxX3NlcnZlcl9tYXBfcGFnZXMoc3RydWN0Cj4gaHZtX2lvcmVxX3NlcnZlciAqcykKPiAg ICAgICAgICByYyA9IGh2bV9tYXBfaW9yZXFfZ2ZuKHMsIHRydWUpOwo+IAo+ICAgICAgaWYgKCBy YyApCj4gLSAgICAgICAgaHZtX3VubWFwX2lvcmVxX2dmbihzLCBmYWxzZSk7Cj4gKyAgICAgICAg aHZtX3VubWFwX2lvcmVxX2dmbihzLCAmcy0+aW9yZXEpOwo+IAo+ICAgICAgcmV0dXJuIHJjOwo+ ICB9Cj4gCj4gIHN0YXRpYyB2b2lkIGh2bV9pb3JlcV9zZXJ2ZXJfdW5tYXBfcGFnZXMoc3RydWN0 IGh2bV9pb3JlcV9zZXJ2ZXIgKnMpCj4gIHsKPiAtICAgIGh2bV91bm1hcF9pb3JlcV9nZm4ocywg dHJ1ZSk7Cj4gLSAgICBodm1fdW5tYXBfaW9yZXFfZ2ZuKHMsIGZhbHNlKTsKPiArICAgIGh2bV91 bm1hcF9pb3JlcV9nZm4ocywgJnMtPmlvcmVxKTsKPiArICAgIGh2bV91bm1hcF9pb3JlcV9nZm4o cywgJnMtPmJ1ZmlvcmVxKTsKPiAgfQo+IAo+ICBzdGF0aWMgaW50IGh2bV9pb3JlcV9zZXJ2ZXJf YWxsb2NfcGFnZXMoc3RydWN0IGh2bV9pb3JlcV9zZXJ2ZXIgKnMpCj4gIHsKPiAgICAgIGludCBy YzsKPiAKPiAtICAgIHJjID0gaHZtX2FsbG9jX2lvcmVxX21mbihzLCBmYWxzZSk7Cj4gKyAgICBy YyA9IGh2bV9hbGxvY19pb3JlcV9tZm4ocywgJnMtPmlvcmVxKTsKPiAKPiAgICAgIGlmICggIXJj ICYmIChzLT5idWZpb3JlcV9oYW5kbGluZyAhPSBIVk1fSU9SRVFTUlZfQlVGSU9SRVFfT0ZGKSAp Cj4gLSAgICAgICAgcmMgPSBodm1fYWxsb2NfaW9yZXFfbWZuKHMsIHRydWUpOwo+ICsgICAgICAg IHJjID0gaHZtX2FsbG9jX2lvcmVxX21mbihzLCAmcy0+YnVmaW9yZXEpOwo+IAo+ICAgICAgaWYg KCByYyApCj4gLSAgICAgICAgaHZtX2ZyZWVfaW9yZXFfbWZuKHMsIGZhbHNlKTsKPiArICAgICAg ICBodm1fZnJlZV9pb3JlcV9tZm4ocywgJnMtPmlvcmVxKTsKPiAKPiAgICAgIHJldHVybiByYzsK PiAgfQo+IAo+ICBzdGF0aWMgdm9pZCBodm1faW9yZXFfc2VydmVyX2ZyZWVfcGFnZXMoc3RydWN0 IGh2bV9pb3JlcV9zZXJ2ZXIgKnMpCj4gIHsKPiAtICAgIGh2bV9mcmVlX2lvcmVxX21mbihzLCB0 cnVlKTsKPiAtICAgIGh2bV9mcmVlX2lvcmVxX21mbihzLCBmYWxzZSk7Cj4gKyAgICBodm1fZnJl ZV9pb3JlcV9tZm4ocywgJnMtPmJ1ZmlvcmVxKTsKPiArICAgIGh2bV9mcmVlX2lvcmVxX21mbihz LCAmcy0+aW9yZXEpOwo+ICB9Cj4gCj4gIHN0YXRpYyB2b2lkIGh2bV9pb3JlcV9zZXJ2ZXJfZnJl ZV9yYW5nZXNldHMoc3RydWN0IGh2bV9pb3JlcV9zZXJ2ZXIgKnMpCj4gQEAgLTY0Niw4ICs2NDQs OCBAQCBzdGF0aWMgdm9pZCBodm1faW9yZXFfc2VydmVyX2VuYWJsZShzdHJ1Y3QKPiBodm1faW9y ZXFfc2VydmVyICpzKQo+ICAgICAgaWYgKCBzLT5lbmFibGVkICkKPiAgICAgICAgICBnb3RvIGRv bmU7Cj4gCj4gLSAgICBodm1fcmVtb3ZlX2lvcmVxX2dmbihzLCBmYWxzZSk7Cj4gLSAgICBodm1f cmVtb3ZlX2lvcmVxX2dmbihzLCB0cnVlKTsKPiArICAgIGh2bV9yZW1vdmVfaW9yZXFfZ2ZuKHMs ICZzLT5pb3JlcSk7Cj4gKyAgICBodm1fcmVtb3ZlX2lvcmVxX2dmbihzLCAmcy0+YnVmaW9yZXEp Owo+IAo+ICAgICAgcy0+ZW5hYmxlZCA9IHRydWU7Cj4gCj4gQEAgLTY2Nyw4ICs2NjUsOCBAQCBz dGF0aWMgdm9pZCBodm1faW9yZXFfc2VydmVyX2Rpc2FibGUoc3RydWN0Cj4gaHZtX2lvcmVxX3Nl cnZlciAqcykKPiAgICAgIGlmICggIXMtPmVuYWJsZWQgKQo+ICAgICAgICAgIGdvdG8gZG9uZTsK PiAKPiAtICAgIGh2bV9hZGRfaW9yZXFfZ2ZuKHMsIHRydWUpOwo+IC0gICAgaHZtX2FkZF9pb3Jl cV9nZm4ocywgZmFsc2UpOwo+ICsgICAgaHZtX2FkZF9pb3JlcV9nZm4ocywgJnMtPmJ1ZmlvcmVx KTsKPiArICAgIGh2bV9hZGRfaW9yZXFfZ2ZuKHMsICZzLT5pb3JlcSk7Cj4gCj4gICAgICBzLT5l bmFibGVkID0gZmFsc2U7Cj4gCj4gLS0KPiAxLjguMy4xCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2 ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWls bWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==