From: Dario Faggioli <dfaggioli@suse.com>
To: andrii.anisov@gmail.com
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@arm.com>,
"andrii_anisov@epam.com" <andrii_anisov@epam.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH] schedule: move last_run_time to the credit scheduler privates
Date: Tue, 11 Sep 2018 18:08:49 +0200 [thread overview]
Message-ID: <ffb0573275ab8116bcf1057effa4c1ab8e3f7fda.camel@suse.com> (raw)
In-Reply-To: <5B977CFF02000078001E70C1@prv1-mh.provo.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1360 bytes --]
On Tue, 2018-09-11 at 02:29 -0600, Jan Beulich wrote:
> > > > On 11.09.18 at 10:10, <andrii.anisov@gmail.com> wrote:
> >
> > From: Andrii Anisov <andrii_anisov@epam.com>
> >
> > diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
> > index 84e744b..7170172 100644
> >
> > @@ -701,10 +704,11 @@ static unsigned int vcpu_migration_delay_us;
> > integer_param("vcpu_migration_delay", vcpu_migration_delay_us);
> >
> > static inline bool
> > -__csched_vcpu_is_cache_hot(const struct csched_private *prv,
> > struct vcpu *v)
> > +__csched_vcpu_is_cache_hot(const struct csched_private *prv,
> > + struct csched_vcpu * scurr)
>
> Stray blank, and it looks like the parameter can be pointer to const.
> Similar further down.
>
And besides this that Jan is saying, I'd name the parameter 'svc'
rather than 'scurr'.
Calling it scurr makes one think that it is always a vcpu that is
currently running on a pcpu which is being passed to the function. But
that, not only is not at all required, but it is not even the case
right now.
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-11 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 8:10 [PATCH] schedule: move last_run_time to the credit scheduler privates Andrii Anisov
2018-09-11 8:29 ` Jan Beulich
2018-09-11 16:08 ` Dario Faggioli [this message]
2018-09-12 8:14 ` Dario Faggioli
2018-09-12 9:26 ` Andrii Anisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffb0573275ab8116bcf1057effa4c1ab8e3f7fda.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=andrii.anisov@gmail.com \
--cc=andrii_anisov@epam.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).