From: "Andres Lagar-Cavilla" <andres@lagarcavilla.org>
To: George Dunlap <george.dunlap@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
"andres@gridcentric.ca" <andres@gridcentric.ca>,
"Tim (Xen.org)" <tim@xen.org>,
"keir.xen@gmail.com" <keir.xen@gmail.com>,
"adin@gridcentric.ca" <adin@gridcentric.ca>
Subject: Re: [PATCH 2 of 5] Clean up locking now that p2m lockups are fully synchronized
Date: Thu, 2 Feb 2012 11:40:46 -0800 [thread overview]
Message-ID: <fff17a2aed000e6aad496ed020eb7a9d.squirrel@webmail.lagarcavilla.org> (raw)
In-Reply-To: <1328193082.21722.31.camel@elijah>
> On Wed, 2012-02-01 at 19:56 +0000, Andres Lagar-Cavilla wrote:
>> @@ -1445,7 +1449,7 @@ p2m_get_nestedp2m(struct vcpu *v, uint64
>> nestedp2m_unlock(d);
>> return p2m;
>> }
>> - p2m_unlock(p2m);
>> + gfn_unlock(p2m, gfn, 0);
>> }
>
> It looks like maybe you forgot to change the corresponding p2m_lock() to
> gfn_lock(), here in p2m.c:p2m_get_nestedp2m()?
Good catch! (evil macro argument squashing!)
Thanks
Andres
>
> Other than that, I think the PoD stuff looks fine. So regarding PoD
> stuff:
> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
>
>
next prev parent reply other threads:[~2012-02-02 19:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 19:56 [PATCH 0 of 5] Synchronized p2m lookups Andres Lagar-Cavilla
2012-02-01 19:56 ` [PATCH 1 of 5] Make p2m lookups fully synchronized wrt modifications Andres Lagar-Cavilla
2012-02-02 13:08 ` Tim Deegan
2012-02-02 14:01 ` Andres Lagar-Cavilla
2012-02-01 19:56 ` [PATCH 2 of 5] Clean up locking now that p2m lockups are fully synchronized Andres Lagar-Cavilla
2012-02-02 13:10 ` Tim Deegan
2012-02-02 14:31 ` George Dunlap
2012-02-02 19:40 ` Andres Lagar-Cavilla [this message]
2012-02-01 19:56 ` [PATCH 3 of 5] Rework locking in the PoD layer Andres Lagar-Cavilla
2012-02-02 13:14 ` Tim Deegan
2012-02-02 14:04 ` Andres Lagar-Cavilla
2012-02-02 15:33 ` George Dunlap
2012-02-02 20:03 ` Andres Lagar-Cavilla
2012-02-01 19:56 ` [PATCH 4 of 5] Re-order calls to put_gfn() around wait queu invocations Andres Lagar-Cavilla
2012-02-02 13:26 ` Tim Deegan
2012-02-01 19:56 ` [PATCH 5 of 5] x86/mm: Revert changeset 24582:f6c33cfe7333 Andres Lagar-Cavilla
2012-02-02 13:27 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fff17a2aed000e6aad496ed020eb7a9d.squirrel@webmail.lagarcavilla.org \
--to=andres@lagarcavilla.org \
--cc=adin@gridcentric.ca \
--cc=andres@gridcentric.ca \
--cc=george.dunlap@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=keir.xen@gmail.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).