From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Andres Lagar-Cavilla" <andres@lagarcavilla.org>
Subject: Re: [PATCH 2 of 5] Clean up locking now that p2m
 lockups are fully synchronized
Date: Thu, 2 Feb 2012 11:40:46 -0800
Message-ID: <fff17a2aed000e6aad496ed020eb7a9d.squirrel@webmail.lagarcavilla.org>
References: <patchbomb.1328126164@xdev.gridcentric.ca>
	<fb9c06df05f20461744a.1328126166@xdev.gridcentric.ca>
	<1328193082.21722.31.camel@elijah>
Reply-To: andres@lagarcavilla.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1328193082.21722.31.camel@elijah>
List-Unsubscribe: <http://lists.xensource.com/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: George Dunlap <george.dunlap@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, George Dunlap <george.dunlap@eu.citrix.com>, "andres@gridcentric.ca" <andres@gridcentric.ca>, "Tim (Xen.org)" <tim@xen.org>, "keir.xen@gmail.com" <keir.xen@gmail.com>, "adin@gridcentric.ca" <adin@gridcentric.ca>
List-Id: xen-devel@lists.xenproject.org

> On Wed, 2012-02-01 at 19:56 +0000, Andres Lagar-Cavilla wrote:
>> @@ -1445,7 +1449,7 @@ p2m_get_nestedp2m(struct vcpu *v, uint64
>>              nestedp2m_unlock(d);
>>              return p2m;
>>          }
>> -        p2m_unlock(p2m);
>> +        gfn_unlock(p2m, gfn, 0);
>>      }
>
> It looks like maybe you forgot to change the corresponding p2m_lock() to
> gfn_lock(), here in p2m.c:p2m_get_nestedp2m()?

Good catch! (evil macro argument squashing!)
Thanks
Andres

>
> Other than that, I think the PoD stuff looks fine.  So regarding PoD
> stuff:
> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
>
>