Re: New release candidate for Xen 3.4.3

["Bryan D. Payne" <bryan@thepaynes.cc>]

> I hope that this will be the final RC before the 3.4.3 release. Please test!

I'm getting a build error with this RC.  I simply did a "make world"
after cloning the repository and end up with the resulting error while
building tools/ioemu-remote/i386-dm:

helper2.c: In function ‘cpu_x86_init’:
helper2.c:150: error: ‘shared_iopage_t’ has no member named ‘vcpu_ioreq’

I've build many other versions of Xen from the source without
problems, so I doubt that this is something unusual with my build
environment.  However, in debugging this I did notice that
'shared_iopage_t' is defined in ioreq.h, which has four locations
inside the build tree:

(1) dist/install/usr/include/xen/hvm/ioreq.h
(2) dist/install/lib/modules/2.6.18.8-xen/source/include/xen/interface/hvm/ioreq.h
(3) linux-2.6.18-xen.hg/include/xen/interface/hvm/ioreq.h
(4) tools/include/xen/hvm/ioreq.h

Comparing these, (1) and (4) are the same and (2) and (3) are the
same.  The definition of shared_iopage_t in (2) and (3) looks like
this:

struct shared_iopage {
    struct ioreq vcpu_ioreq[1];
};
typedef struct shared_iopage shared_iopage_t;

And the definition of shared_iopage_t in (1) and (4) looks like this:

struct shared_iopage {
    struct vcpu_iodata   vcpu_iodata[1];
};
typedef struct shared_iopage shared_iopage_t;

I'm not sure what's going on here, but it seems like it could be a bug
in the build system.  Since this is an RC, I wanted to report it and
see if anyone can comment on why this is happening.

Thanks,
bryan