From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Bryan D. Payne" <bryan@thepaynes.cc>
Subject: Re: New release candidate for Xen 3.4.3
Date: Thu, 22 Apr 2010 16:24:52 -0400
Message-ID: <i2s64bddf0e1004221324x63821697pbfcb13ba9dee7199@mail.gmail.com>
References: <C7F5CC8C.12145%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C7F5CC8C.12145%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

> I hope that this will be the final RC before the 3.4.3 release. Please te=
st!

I'm getting a build error with this RC.  I simply did a "make world"
after cloning the repository and end up with the resulting error while
building tools/ioemu-remote/i386-dm:

helper2.c: In function =91cpu_x86_init=92:
helper2.c:150: error: =91shared_iopage_t=92 has no member named =91vcpu_ior=
eq=92

I've build many other versions of Xen from the source without
problems, so I doubt that this is something unusual with my build
environment.  However, in debugging this I did notice that
'shared_iopage_t' is defined in ioreq.h, which has four locations
inside the build tree:

(1) dist/install/usr/include/xen/hvm/ioreq.h
(2) dist/install/lib/modules/2.6.18.8-xen/source/include/xen/interface/hvm/=
ioreq.h
(3) linux-2.6.18-xen.hg/include/xen/interface/hvm/ioreq.h
(4) tools/include/xen/hvm/ioreq.h

Comparing these, (1) and (4) are the same and (2) and (3) are the
same.  The definition of shared_iopage_t in (2) and (3) looks like
this:

struct shared_iopage {
    struct ioreq vcpu_ioreq[1];
};
typedef struct shared_iopage shared_iopage_t;

And the definition of shared_iopage_t in (1) and (4) looks like this:

struct shared_iopage {
    struct vcpu_iodata   vcpu_iodata[1];
};
typedef struct shared_iopage shared_iopage_t;

I'm not sure what's going on here, but it seems like it could be a bug
in the build system.  Since this is an RC, I wanted to report it and
see if anyone can comment on why this is happening.

Thanks,
bryan