From: Jonathan Creekmore <jonathan.creekmore@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Jonathan Creekmore <jonathan.creekmore@gmail.com>,
Dario Faggioli <dario.faggioli@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/4] build: Hook the schedulers into Kconfig
Date: Fri, 18 Dec 2015 10:43:35 -0600 [thread overview]
Message-ID: <m2io3v4si0.fsf@Nebula.lan> (raw)
In-Reply-To: <5673CA73.3030007@citrix.com>
Andrew Cooper writes:
> On 17/12/2015 20:59, Jonathan Creekmore wrote:
>> Allow the schedulers to be independently enabled or disabled at
>> compile-time instead of just allowing the scheduler to be selected on
>> the command line. To match existing behavior, all four schedulers are
>> compiled in by default, although the RTDS and ARINC653 are marked
>> EXPERIMENTAL to match their not currently supported status.
>>
>> CC: George Dunlap <george.dunlap@eu.citrix.com>
>> CC: Dario Faggioli <dario.faggioli@citrix.com>
>> Signed-off-by: Jonathan Creekmore <jonathan.creekmore@gmail.com>
>
> With the suggestions Dario made, and one minor nit below,
>
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
I plan on making those changes.
>> diff --git a/xen/common/Makefile b/xen/common/Makefile
>> index 8ab15ba..3a2026a 100644
>> --- a/xen/common/Makefile
>> +++ b/xen/common/Makefile
>> @@ -30,10 +30,10 @@ obj-y += rangeset.o
>> obj-y += radix-tree.o
>> obj-y += rbtree.o
>> obj-y += rcupdate.o
>> -obj-y += sched_credit.o
>> -obj-y += sched_credit2.o
>> -obj-y += sched_arinc653.o
>> -obj-y += sched_rt.o
>> +obj-$(CONFIG_SCHED_CREDIT) += sched_credit.o
>> +obj-$(CONFIG_SCHED_CREDIT2) += sched_credit2.o
>> +obj-$(CONFIG_SCHED_ARINC653) += sched_arinc653.o
>> +obj-$(CONFIG_SCHED_RTDS) += sched_rt.o
>
> I know it was wrong before, but please reorder
Easy enough to do. I will take care of that.
next prev parent reply other threads:[~2015-12-18 16:43 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 20:59 [PATCH 0/4] Allow schedulers to be selectable through Kconfig Jonathan Creekmore
2015-12-17 20:59 ` [PATCH 1/4] build: Hook the schedulers into Kconfig Jonathan Creekmore
2015-12-18 1:35 ` Dario Faggioli
2015-12-18 2:20 ` Jonathan Creekmore
2015-12-18 9:19 ` Dario Faggioli
2015-12-18 10:52 ` George Dunlap
2015-12-18 11:23 ` Dario Faggioli
2015-12-18 8:57 ` Andrew Cooper
2015-12-18 16:43 ` Jonathan Creekmore [this message]
2015-12-17 20:59 ` [PATCH 2/4] build: Alloc space for sched list in the link file Jonathan Creekmore
2015-12-18 9:01 ` Andrew Cooper
2015-12-18 16:40 ` Jonathan Creekmore
2015-12-18 16:48 ` Andrew Cooper
2015-12-18 17:07 ` Jan Beulich
2015-12-18 17:10 ` Andrew Cooper
2015-12-18 17:11 ` Jonathan Creekmore
2015-12-18 17:23 ` Andrew Cooper
2015-12-17 20:59 ` [PATCH 3/4] sched: Register the schedulers into the list Jonathan Creekmore
2015-12-18 1:42 ` Dario Faggioli
2015-12-18 9:03 ` Andrew Cooper
2015-12-17 20:59 ` [PATCH 4/4] sched: Use the auto-generated list of schedulers Jonathan Creekmore
2015-12-18 1:47 ` Dario Faggioli
2015-12-18 9:12 ` Andrew Cooper
2015-12-18 16:44 ` Jonathan Creekmore
2015-12-18 10:50 ` Jan Beulich
2015-12-18 16:00 ` Jonathan Creekmore
2015-12-18 16:43 ` Jan Beulich
2015-12-18 17:24 ` Jonathan Creekmore
2015-12-18 17:30 ` Andrew Cooper
2015-12-18 10:39 ` [PATCH 0/4] Allow schedulers to be selectable through Kconfig Jan Beulich
2015-12-18 10:45 ` Ian Campbell
2015-12-18 10:58 ` Jan Beulich
2015-12-18 11:08 ` Juergen Gross
2015-12-18 11:19 ` Ian Campbell
2015-12-18 11:30 ` Jan Beulich
[not found] ` <5673FC6202000078000C122B@suse.com>
2015-12-18 11:41 ` Juergen Gross
2015-12-18 17:56 ` Doug Goldstein
2015-12-18 18:25 ` Andrew Cooper
2016-01-06 14:45 ` Ian Campbell
2016-01-07 14:01 ` Jonathan Creekmore
2016-01-07 14:37 ` Jan Beulich
2016-01-07 15:00 ` Ian Campbell
2016-01-07 15:18 ` Doug Goldstein
2016-01-07 15:31 ` Ian Campbell
2016-01-07 15:43 ` Jonathan Creekmore
2016-01-07 15:54 ` Jan Beulich
2016-01-07 15:47 ` Jan Beulich
2016-01-07 15:30 ` Ian Campbell
2016-01-07 15:51 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2io3v4si0.fsf@Nebula.lan \
--to=jonathan.creekmore@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).