xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Kinzler" <ml-ak@posteo.de>
To: Wei Liu <wei.liu2@citrix.com>, George Dunlap <george.dunlap@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: race in vif-common.sh
Date: Thu, 27 Jul 2017 18:12:57 +0200	[thread overview]
Message-ID: <op.y31lzzlx7b6b3e@kriftel> (raw)
In-Reply-To: <ada6b880-a429-f2d7-a19e-650906655597@citrix.com>

On Thu, 27 Jul 2017 12:55:14 +0200, George Dunlap  
<george.dunlap@citrix.com> wrote:
> For 4.9 we checked in a fix to this problem that would specifically
> attempt to use the -w option if it was available; see c/s 3d2010f9ff.

Sorry, I think that this patch is just far to complicated. If you really  
want to keep the "iptables is working check" (lines 1-7 of function  
handle_iptable) then you should just move it inside the claim_lock  
"iptables" section and you won't need any -w option and no iptables_w()  
check.

Regards Andreas

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-07-27 16:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03 11:30 race in vif-common.sh Andreas Kinzler
2017-07-03 13:07 ` Wei Liu
2017-07-27 10:55   ` George Dunlap
2017-07-27 16:12     ` Andreas Kinzler [this message]
2017-07-27 16:49       ` George Dunlap
2017-07-27 17:11         ` Andreas Kinzler
2017-07-27 20:13           ` George Dunlap
     [not found] <c78e6100-18d6-87c3-b67b-c2088e071b4c@posteo.de>
2017-07-03 11:28 ` Andreas Kinzler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.y31lzzlx7b6b3e@kriftel \
    --to=ml-ak@posteo.de \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).