From: "Andreas Kinzler" <hfp@posteo.de>
To: "Roger Pau Monné" <roger.pau@citrix.com>,
"Jan Beulich" <JBeulich@suse.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: Regression PCI passthrough from 4.5.5 to 4.6.0-rc1
Date: Wed, 23 Aug 2017 19:13:00 +0200 [thread overview]
Message-ID: <op.y5for2vsollboj@kriftel> (raw)
In-Reply-To: <20170822080629.23fldcvxqxbywl42@MacBook-Pro-de-Roger.local>
>> > From a brief look it looks like this would be doable, but the way
>> these flags are being communicated is rather ugly (the values used here
>> > aren't part of the public interface, and hence it wasn't immediately
>> > clear whether using one of the unused bits would be an option, but
>> > it looks like it is).
>> Yes, it's not pretty... Last used bit is 15, hence bit 16 could be
>> used to signal to Xen whether the interrupt should be unmasked after
>> binding. I have a half-drafted patch, will finish it now.
> Andreas, could you please give a try to the attached two patches? One
> is for Xen and the other one is for QEMU.
Seems to work after I fixed a bug ;-)
-gflags |= masked ? 0 : XEN_PT_GFLAGSSHIFT_UNMASKED;
+gflags |= masked ? 0 : (1 << XEN_PT_GFLAGSSHIFT_UNMASKED);
Please let Jan and/or others review the patches.
Regards Andreas
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-23 17:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 16:39 Regression PCI passthrough from 4.5.5 to 4.6.0-rc1 Andreas Kinzler
2017-07-09 19:26 ` Pasi Kärkkäinen
2017-07-10 16:56 ` Andreas Kinzler
2017-07-14 11:46 ` Jan Beulich
2017-07-17 16:32 ` Andreas Kinzler
2017-07-21 8:51 ` Pasi Kärkkäinen
2017-07-31 10:12 ` Jan Beulich
2017-08-14 11:31 ` Andreas Kinzler
2017-08-14 11:44 ` Jan Beulich
2017-08-14 11:56 ` Roger Pau Monné
2017-08-14 12:08 ` Andreas Kinzler
2017-08-15 9:55 ` Roger Pau Monné
2017-08-15 11:00 ` Roger Pau Monné
2017-08-15 12:12 ` Jan Beulich
2017-08-15 12:29 ` Roger Pau Monné
2017-08-17 17:36 ` Andreas Kinzler
2017-08-18 7:16 ` Jan Beulich
2017-08-18 11:03 ` Roger Pau Monné
2017-08-21 9:09 ` Andreas Kinzler
2017-08-21 9:46 ` Roger Pau Monné
2017-08-21 11:26 ` Andreas Kinzler
2017-08-21 12:22 ` Jan Beulich
2017-08-21 12:32 ` Andreas Kinzler
2017-08-21 12:39 ` Jan Beulich
2017-08-21 14:49 ` Roger Pau Monné
2017-08-21 15:14 ` Jan Beulich
2017-08-21 15:18 ` Roger Pau Monné
2017-08-22 8:06 ` Roger Pau Monné
2017-08-23 17:13 ` Andreas Kinzler [this message]
2017-08-24 8:23 ` Roger Pau Monné
2017-11-02 17:02 ` Pasi Kärkkäinen
2017-11-02 17:11 ` Roger Pau Monné
2017-11-02 17:13 ` Pasi Kärkkäinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.y5for2vsollboj@kriftel \
--to=hfp@posteo.de \
--cc=JBeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).