* [xen-unstable test] 12988: regressions - FAIL
@ 2012-05-30 8:30 xen.org
2012-05-30 9:44 ` Ian Campbell
0 siblings, 1 reply; 11+ messages in thread
From: xen.org @ 2012-05-30 8:30 UTC (permalink / raw)
To: xen-devel; +Cc: ian.jackson
flight 12988 xen-unstable real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/12988/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-i386-oldkern 4 xen-build fail REGR. vs. 12979
Regressions which are regarded as allowable (not blocking):
test-amd64-amd64-xl-qemuu-win7-amd64 12 guest-localmigrate/x10 fail like 12979
Tests which did not succeed, but are not blocking:
test-amd64-amd64-xl-pcipt-intel 9 guest-start fail never pass
test-amd64-i386-rhel6hvm-intel 11 leak-check/check fail never pass
test-amd64-i386-qemuu-rhel6hvm-amd 11 leak-check/check fail never pass
test-amd64-i386-qemuu-rhel6hvm-intel 11 leak-check/check fail never pass
test-amd64-i386-xend-winxpsp3 16 leak-check/check fail never pass
test-amd64-amd64-xl-qemuu-winxpsp3 13 guest-stop fail never pass
test-amd64-amd64-win 16 leak-check/check fail never pass
test-amd64-i386-xl-win-vcpus1 13 guest-stop fail never pass
test-i386-i386-xl-qemuu-winxpsp3 13 guest-stop fail never pass
test-amd64-i386-win-vcpus1 16 leak-check/check fail never pass
test-amd64-i386-rhel6hvm-amd 11 leak-check/check fail never pass
test-i386-i386-xl-winxpsp3 13 guest-stop fail never pass
test-amd64-i386-xl-win7-amd64 13 guest-stop fail never pass
test-amd64-amd64-xl-winxpsp3 13 guest-stop fail never pass
test-amd64-i386-win 16 leak-check/check fail never pass
test-amd64-i386-xl-winxpsp3-vcpus1 13 guest-stop fail never pass
test-amd64-amd64-xl-win7-amd64 13 guest-stop fail never pass
test-i386-i386-win 16 leak-check/check fail never pass
test-i386-i386-xl-win 13 guest-stop fail never pass
test-amd64-amd64-xl-win 13 guest-stop fail never pass
version targeted for testing:
xen 894493e84fe7
baseline version:
xen 52ffce7a036e
jobs:
build-amd64 pass
build-i386 pass
build-amd64-oldkern pass
build-i386-oldkern fail
build-amd64-pvops pass
build-i386-pvops pass
test-amd64-amd64-xl pass
test-amd64-i386-xl pass
test-i386-i386-xl pass
test-amd64-i386-rhel6hvm-amd fail
test-amd64-i386-qemuu-rhel6hvm-amd fail
test-amd64-amd64-xl-qemuu-win7-amd64 fail
test-amd64-amd64-xl-win7-amd64 fail
test-amd64-i386-xl-win7-amd64 fail
test-amd64-i386-xl-credit2 pass
test-amd64-amd64-xl-pcipt-intel fail
test-amd64-i386-rhel6hvm-intel fail
test-amd64-i386-qemuu-rhel6hvm-intel fail
test-amd64-i386-xl-multivcpu pass
test-amd64-amd64-pair pass
test-amd64-i386-pair pass
test-i386-i386-pair pass
test-amd64-amd64-xl-sedf-pin pass
test-amd64-amd64-pv pass
test-amd64-i386-pv pass
test-i386-i386-pv pass
test-amd64-amd64-xl-sedf pass
test-amd64-i386-win-vcpus1 fail
test-amd64-i386-xl-win-vcpus1 fail
test-amd64-i386-xl-winxpsp3-vcpus1 fail
test-amd64-amd64-win fail
test-amd64-i386-win fail
test-i386-i386-win fail
test-amd64-amd64-xl-win fail
test-i386-i386-xl-win fail
test-amd64-amd64-xl-qemuu-winxpsp3 fail
test-i386-i386-xl-qemuu-winxpsp3 fail
test-amd64-i386-xend-winxpsp3 fail
test-amd64-amd64-xl-winxpsp3 fail
test-i386-i386-xl-winxpsp3 fail
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Not pushing.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 12988: regressions - FAIL
2012-05-30 8:30 [xen-unstable test] 12988: regressions - FAIL xen.org
@ 2012-05-30 9:44 ` Ian Campbell
2012-05-30 9:46 ` Ian Campbell
0 siblings, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2012-05-30 9:44 UTC (permalink / raw)
To: xen.org; +Cc: xen-devel@lists.xensource.com
On Wed, 2012-05-30 at 09:30 +0100, xen.org wrote:
> flight 12988 xen-unstable real [real]
> http://www.chiark.greenend.org.uk/~xensrcts/logs/12988/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> build-i386-oldkern 4 xen-build fail REGR. vs. 12979
This is failing with:
In file included from xl.c:33:
xl.h:20:20: error: _paths.h: No such file or directory
xl.c: In function 'parse_global_config':
xl.c:76: error: 'XEN_LOCK_DIR' undeclared (first use in this function)
xl.c:76: error: (Each undeclared identifier is reported only once
xl.c:76: error: for each function it appears in.)
xl.c:76: error: expected ')' before string constant
xl.c:76: error: expected ')' before string constant
xl.c:76: error: expected ')' before string constant
xl.c:76: error: expected ')' before string constant
xl.c:76: error: expected ')' before string constant
xl.c:76: error: expected ')' before string constant
xl.c:76: error: too few arguments to function 'memcpy'
xl.c:76: error: expected ')' before string constant
xl.c: In function 'main':
xl.c:230: error: 'XEN_CONFIG_DIR' undeclared (first use in this function)
xl.c:230: error: expected ')' before string constant
xl.c:231: error: too few arguments to function 'libxl_read_file_contents'
xl.c:234: error: expected ')' before string constant
xl.c:235: error: expected ')' before string constant
xl.c:235: error: too few arguments to function 'parse_global_config'
cc1: warnings being treated as errors
xl.c:197: error: unused variable 'config_len'
make[3]: *** [xl.o] Error 1
But I've no idea why it would be failing here and not in the other
build-* targets. It seems likely that this is related to:
changeset: 25409:894493e84fe7
user: Ian Campbell <ian.campbell@citrix.com>
date: Tue May 29 16:44:06 2012 +0100
files: tools/libxl/Makefile tools/libxl/libxl.h tools/libxl/libxl_internal.h tools/libxl/libxl_paths.c tools/libxl/xl.c tools/libxl/xl.h
description:
libxl: remove lockdir and config dir from the API
These are only used by xl.
Rename _libxl_paths.h -> _paths.h, these are not actually "libxl" paths but
rather are part of the Xen build time configuration. It is fine for xl to also
consume them.
But I can't see anything wrong there and it builds/works for me.
>
> Regressions which are regarded as allowable (not blocking):
> test-amd64-amd64-xl-qemuu-win7-amd64 12 guest-localmigrate/x10 fail like 12979
>
> Tests which did not succeed, but are not blocking:
> test-amd64-amd64-xl-pcipt-intel 9 guest-start fail never pass
> test-amd64-i386-rhel6hvm-intel 11 leak-check/check fail never pass
> test-amd64-i386-qemuu-rhel6hvm-amd 11 leak-check/check fail never pass
> test-amd64-i386-qemuu-rhel6hvm-intel 11 leak-check/check fail never pass
> test-amd64-i386-xend-winxpsp3 16 leak-check/check fail never pass
> test-amd64-amd64-xl-qemuu-winxpsp3 13 guest-stop fail never pass
> test-amd64-amd64-win 16 leak-check/check fail never pass
> test-amd64-i386-xl-win-vcpus1 13 guest-stop fail never pass
> test-i386-i386-xl-qemuu-winxpsp3 13 guest-stop fail never pass
> test-amd64-i386-win-vcpus1 16 leak-check/check fail never pass
> test-amd64-i386-rhel6hvm-amd 11 leak-check/check fail never pass
> test-i386-i386-xl-winxpsp3 13 guest-stop fail never pass
> test-amd64-i386-xl-win7-amd64 13 guest-stop fail never pass
> test-amd64-amd64-xl-winxpsp3 13 guest-stop fail never pass
> test-amd64-i386-win 16 leak-check/check fail never pass
> test-amd64-i386-xl-winxpsp3-vcpus1 13 guest-stop fail never pass
> test-amd64-amd64-xl-win7-amd64 13 guest-stop fail never pass
> test-i386-i386-win 16 leak-check/check fail never pass
> test-i386-i386-xl-win 13 guest-stop fail never pass
> test-amd64-amd64-xl-win 13 guest-stop fail never pass
>
> version targeted for testing:
> xen 894493e84fe7
> baseline version:
> xen 52ffce7a036e
>
> jobs:
> build-amd64 pass
> build-i386 pass
> build-amd64-oldkern pass
> build-i386-oldkern fail
> build-amd64-pvops pass
> build-i386-pvops pass
> test-amd64-amd64-xl pass
> test-amd64-i386-xl pass
> test-i386-i386-xl pass
> test-amd64-i386-rhel6hvm-amd fail
> test-amd64-i386-qemuu-rhel6hvm-amd fail
> test-amd64-amd64-xl-qemuu-win7-amd64 fail
> test-amd64-amd64-xl-win7-amd64 fail
> test-amd64-i386-xl-win7-amd64 fail
> test-amd64-i386-xl-credit2 pass
> test-amd64-amd64-xl-pcipt-intel fail
> test-amd64-i386-rhel6hvm-intel fail
> test-amd64-i386-qemuu-rhel6hvm-intel fail
> test-amd64-i386-xl-multivcpu pass
> test-amd64-amd64-pair pass
> test-amd64-i386-pair pass
> test-i386-i386-pair pass
> test-amd64-amd64-xl-sedf-pin pass
> test-amd64-amd64-pv pass
> test-amd64-i386-pv pass
> test-i386-i386-pv pass
> test-amd64-amd64-xl-sedf pass
> test-amd64-i386-win-vcpus1 fail
> test-amd64-i386-xl-win-vcpus1 fail
> test-amd64-i386-xl-winxpsp3-vcpus1 fail
> test-amd64-amd64-win fail
> test-amd64-i386-win fail
> test-i386-i386-win fail
> test-amd64-amd64-xl-win fail
> test-i386-i386-xl-win fail
> test-amd64-amd64-xl-qemuu-winxpsp3 fail
> test-i386-i386-xl-qemuu-winxpsp3 fail
> test-amd64-i386-xend-winxpsp3 fail
> test-amd64-amd64-xl-winxpsp3 fail
> test-i386-i386-xl-winxpsp3 fail
>
>
> ------------------------------------------------------------
> sg-report-flight on woking.cam.xci-test.com
> logs: /home/xc_osstest/logs
> images: /home/xc_osstest/images
>
> Logs, config files, etc. are available at
> http://www.chiark.greenend.org.uk/~xensrcts/logs
>
> Test harness code can be found at
> http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
>
>
> Not pushing.
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 12988: regressions - FAIL
2012-05-30 9:44 ` Ian Campbell
@ 2012-05-30 9:46 ` Ian Campbell
2012-05-30 9:57 ` Ian Jackson
0 siblings, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2012-05-30 9:46 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel@lists.xensource.com
On Wed, 2012-05-30 at 10:44 +0100, Ian Campbell wrote:
> It seems likely that this is related to:
> changeset: 25409:894493e84fe7
> user: Ian Campbell <ian.campbell@citrix.com>
> date: Tue May 29 16:44:06 2012 +0100
> files: tools/libxl/Makefile tools/libxl/libxl.h tools/libxl/libxl_internal.h tools/libxl/libxl_paths.c tools/libxl/xl.c tools/libxl/xl.h
> description:
> libxl: remove lockdir and config dir from the API
>
> These are only used by xl.
>
> Rename _libxl_paths.h -> _paths.h, these are not actually "libxl" paths but
> rather are part of the Xen build time configuration. It is fine for xl to also
> consume them.
>
> But I can't see anything wrong there [...]
Yes, I can. I reckon this is the fix.
8<-----------
# HG changeset patch
# User Ian Campbell <ian.campbell@citrix.com>
# Date 1338371140 -3600
# Node ID 017b76385a4c77ec3fb9dd791b6c7d19d0be401c
# Parent 2fef99911c6f179297b47e24246810d92d08d348
xl: xl.h depends on geenrated file _paths.h
Fixes build error.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
diff -r 2fef99911c6f -r 017b76385a4c tools/libxl/Makefile
--- a/tools/libxl/Makefile Wed May 30 10:33:55 2012 +0100
+++ b/tools/libxl/Makefile Wed May 30 10:45:40 2012 +0100
@@ -120,6 +120,7 @@ libxl.h: _libxl_types.h
libxl_json.h: _libxl_types_json.h
libxl_internal.h: _libxl_types_internal.h _paths.h
libxl_internal_json.h: _libxl_types_internal_json.h
+xl.h: _paths.h
$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): libxl.h
$(LIBXL_OBJS): libxl_internal.h
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 12988: regressions - FAIL
2012-05-30 9:46 ` Ian Campbell
@ 2012-05-30 9:57 ` Ian Jackson
2012-05-31 12:58 ` Ben Guthro
0 siblings, 1 reply; 11+ messages in thread
From: Ian Jackson @ 2012-05-30 9:57 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel@lists.xensource.com
Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 12988: regressions - FAIL"):
> xl: xl.h depends on geenrated file _paths.h
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 12988: regressions - FAIL
2012-05-30 9:57 ` Ian Jackson
@ 2012-05-31 12:58 ` Ben Guthro
2012-05-31 13:04 ` Ben Guthro
0 siblings, 1 reply; 11+ messages in thread
From: Ben Guthro @ 2012-05-31 12:58 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel@lists.xensource.com, Ian Campbell
I think something is wrong with this...
a distclean now causes the following build failure:
xen-4.2/tools/libxl$ make distclean
rm -f -f _*.h *.o *.so* *.a xl testidl .*.d
rm -f -f _*.c *.pyc _paths.*.tmp
rm -f -f testidl.c.new testidl.c
xen-4.2/tools/libxl$ make
perl /data/home/bguthro/dev/orc-precise.git/orc-xen/xen-4.2/tools/libxl/../../tools/include/xen-external/bsd-sys-queue-h-seddery
/data/home/bguthro/dev/orc-precise.git/orc-xen/xen-4.2/tools/libxl/../../tools/include/xen-external/bsd-sys-queue.h
--prefix=libxl >_libxl_list.h.new
if ! cmp -s _libxl_list.h.new _libxl_list.h; then mv -f
_libxl_list.h.new _libxl_list.h; else rm -f _libxl_list.h.new; fi
python gentypes.py libxl_types.idl __libxl_types.h
__libxl_types_json.h __libxl_types.c
Parsing libxl_types.idl
outputting libxl type definitions to __libxl_types.h
outputting libxl JSON definitions to __libxl_types_json.h
outputting libxl type implementations to __libxl_types.c
if ! cmp -s __libxl_types.h _libxl_types.h; then mv -f __libxl_types.h
_libxl_types.h; else rm -f __libxl_types.h; fi
if ! cmp -s __libxl_types_json.h _libxl_types_json.h; then mv -f
__libxl_types_json.h _libxl_types_json.h; else rm -f
__libxl_types_json.h; fi
if ! cmp -s __libxl_types.c _libxl_types.c; then mv -f __libxl_types.c
_libxl_types.c; else rm -f __libxl_types.c; fi
gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing
-std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable -D__XEN_TOOLS__ -MMD -MF .xl.o.d
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls
-Werror -Wno-format-zero-length -Wmissing-declarations
-Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC
-pthread -I/data/home/bguthro/dev/orc-precise.git/orc-xen/xen-4.2/tools/libxl/../../tools/libxc
-I/data/home/bguthro/dev/orc-precise.git/orc-xen/xen-4.2/tools/libxl/../../tools/include
-I/data/home/bguthro/dev/orc-precise.git/orc-xen/xen-4.2/tools/libxl/../../tools/libxl
-I/data/home/bguthro/dev/orc-precise.git/orc-xen/xen-4.2/tools/libxl/../../tools/libxc
-I/data/home/bguthro/dev/orc-precise.git/orc-xen/xen-4.2/tools/libxl/../../tools/include
-I/data/home/bguthro/dev/orc-precise.git/orc-xen/xen-4.2/tools/libxl/../../tools/include
-include /data/home/bguthro/dev/orc-precise.git/orc-xen/xen-4.2/tools/libxl/../../tools/config.h
-c -o xl.o xl.c
In file included from xl.c:33:0:
xl.h:20:20: fatal error: _paths.h: No such file or directory
compilation terminated.
make: *** [xl.o] Error 1
On Wed, May 30, 2012 at 5:57 AM, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 12988: regressions - FAIL"):
>> xl: xl.h depends on geenrated file _paths.h
>
> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 12988: regressions - FAIL
2012-05-31 12:58 ` Ben Guthro
@ 2012-05-31 13:04 ` Ben Guthro
2012-05-31 14:25 ` Ian Campbell
2012-05-31 15:10 ` Ian Jackson
0 siblings, 2 replies; 11+ messages in thread
From: Ben Guthro @ 2012-05-31 13:04 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel@lists.xensource.com, Ian Campbell
Fix build error, after distclean
Signed-off-by: Ben Guthro <benjamin.guthro@citrix.com>
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index 8f78c05..bd2cf9d 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -122,7 +122,7 @@ libxl_internal.h: _libxl_types_internal.h _paths.h
libxl_internal_json.h: _libxl_types_internal_json.h
xl.h: _paths.h
-$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): libxl.h
+$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): libxl.h xl.h
$(LIBXL_OBJS): libxl_internal.h
_libxl_type%.h _libxl_type%_json.h _libxl_type%.c: libxl_type%.idl
gentypes.py idl.py
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 12988: regressions - FAIL
2012-05-31 13:04 ` Ben Guthro
@ 2012-05-31 14:25 ` Ian Campbell
2012-05-31 15:10 ` Ian Jackson
1 sibling, 0 replies; 11+ messages in thread
From: Ian Campbell @ 2012-05-31 14:25 UTC (permalink / raw)
To: Ben Guthro; +Cc: xen-devel@lists.xensource.com, Ian Jackson
On Thu, 2012-05-31 at 14:04 +0100, Ben Guthro wrote:
> Fix build error, after distclean
>
> Signed-off-by: Ben Guthro <benjamin.guthro@citrix.com>
>
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index 8f78c05..bd2cf9d 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -122,7 +122,7 @@ libxl_internal.h: _libxl_types_internal.h _paths.h
> libxl_internal_json.h: _libxl_types_internal_json.h
> xl.h: _paths.h
>
> -$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): libxl.h
> +$(LIBXL_OBJS) $(LIBXLU_OBJS) $(XL_OBJS): libxl.h xl.h
This isn't quite accurate, LIBXL*_OBJS don't need xl.h.
It'd be better to add a separate
$(XL_OBJS): xl.h
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 12988: regressions - FAIL
2012-05-31 13:04 ` Ben Guthro
2012-05-31 14:25 ` Ian Campbell
@ 2012-05-31 15:10 ` Ian Jackson
2012-05-31 15:35 ` Ben Guthro
2012-06-01 16:48 ` Ian Campbell
1 sibling, 2 replies; 11+ messages in thread
From: Ian Jackson @ 2012-05-31 15:10 UTC (permalink / raw)
To: Ben Guthro; +Cc: xen-devel@lists.xensource.com, Ian Campbell
Ben Guthro writes ("Re: [Xen-devel] [xen-unstable test] 12988: regressions - FAIL"):
> Fix build error, after distclean
I think in fact the right fix is probably more like this. What do you
think ?
Ian.
diff -r e53a1d3c212c tools/libxl/Makefile
--- a/tools/libxl/Makefile Wed May 30 10:57:10 2012 +0100
+++ b/tools/libxl/Makefile Thu May 31 16:10:11 2012 +0100
@@ -72,7 +72,7 @@ LIBXL_OBJS += _libxl_types.o libxl_flask
$(LIBXL_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenguest) $(CFLAGS_libxenstore) $(CFLAGS_libblktapctl) -include $(XEN_ROOT)/tools/config.h
-AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h
+AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h
AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \
libxlu_disk_l.o libxlu_disk.o libxlu_vif.o libxlu_pci.o
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 12988: regressions - FAIL
2012-05-31 15:10 ` Ian Jackson
@ 2012-05-31 15:35 ` Ben Guthro
2012-06-01 16:48 ` Ian Campbell
1 sibling, 0 replies; 11+ messages in thread
From: Ben Guthro @ 2012-05-31 15:35 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel@lists.xensource.com, Ian Campbell
That works in my tree, and seems to be the best solution, yet
Ben
On Thu, May 31, 2012 at 11:10 AM, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Ben Guthro writes ("Re: [Xen-devel] [xen-unstable test] 12988: regressions - FAIL"):
>> Fix build error, after distclean
>
> I think in fact the right fix is probably more like this. What do you
> think ?
>
> Ian.
>
> diff -r e53a1d3c212c tools/libxl/Makefile
> --- a/tools/libxl/Makefile Wed May 30 10:57:10 2012 +0100
> +++ b/tools/libxl/Makefile Thu May 31 16:10:11 2012 +0100
> @@ -72,7 +72,7 @@ LIBXL_OBJS += _libxl_types.o libxl_flask
>
> $(LIBXL_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenguest) $(CFLAGS_libxenstore) $(CFLAGS_libblktapctl) -include $(XEN_ROOT)/tools/config.h
>
> -AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h
> +AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h
> AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
> LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \
> libxlu_disk_l.o libxlu_disk.o libxlu_vif.o libxlu_pci.o
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 12988: regressions - FAIL
2012-05-31 15:10 ` Ian Jackson
2012-05-31 15:35 ` Ben Guthro
@ 2012-06-01 16:48 ` Ian Campbell
2012-06-01 17:02 ` Ian Jackson
1 sibling, 1 reply; 11+ messages in thread
From: Ian Campbell @ 2012-06-01 16:48 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel@lists.xensource.com, Ben Guthro
On Thu, 2012-05-31 at 16:10 +0100, Ian Jackson wrote:
> Ben Guthro writes ("Re: [Xen-devel] [xen-unstable test] 12988: regressions - FAIL"):
> > Fix build error, after distclean
>
> I think in fact the right fix is probably more like this. What do you
> think ?
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Subject to a suitable commit message being inserted..
>
> Ian.
>
> diff -r e53a1d3c212c tools/libxl/Makefile
> --- a/tools/libxl/Makefile Wed May 30 10:57:10 2012 +0100
> +++ b/tools/libxl/Makefile Thu May 31 16:10:11 2012 +0100
> @@ -72,7 +72,7 @@ LIBXL_OBJS += _libxl_types.o libxl_flask
>
> $(LIBXL_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenguest) $(CFLAGS_libxenstore) $(CFLAGS_libblktapctl) -include $(XEN_ROOT)/tools/config.h
>
> -AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h
> +AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h
> AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
> LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \
> libxlu_disk_l.o libxlu_disk.o libxlu_vif.o libxlu_pci.o
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 12988: regressions - FAIL
2012-06-01 16:48 ` Ian Campbell
@ 2012-06-01 17:02 ` Ian Jackson
0 siblings, 0 replies; 11+ messages in thread
From: Ian Jackson @ 2012-06-01 17:02 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel@lists.xensource.com, Ben Guthro
Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 12988: regressions - FAIL"):
> On Thu, 2012-05-31 at 16:10 +0100, Ian Jackson wrote:
> > I think in fact the right fix is probably more like this. What do you
> > think ?
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Subject to a suitable commit message being inserted..
Thanks.
Ian.
# HG changeset patch
# User Ian Jackson <Ian.Jackson@eu.citrix.com>
# Date 1338570123 -3600
# Node ID 1e2ce970f0f29af4184d975c4f161f11938070cf
# Parent 3b4346d6002e9ffcd4a9f50b031bd2a77b16b1dd
libxl: fix Makefile race bug relating to _paths.h
_paths.h needs to be in AUTOINCS. That arranges for it to be an
explicit dependency of all object files. This is necessary so that it
is made before any compilation is attempted.
Making it a dependency of xl.h (as in 25426:e53a1d3c212c) is harmless,
but not sufficient because that only takes effect if there is already
an autogenerated .d file naming xl.h as a dependency of relevant
object files.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff -r 3b4346d6002e -r 1e2ce970f0f2 tools/libxl/Makefile
--- a/tools/libxl/Makefile Fri Jun 01 12:06:22 2012 +0100
+++ b/tools/libxl/Makefile Fri Jun 01 18:02:03 2012 +0100
@@ -72,7 +72,7 @@ LIBXL_OBJS += _libxl_types.o libxl_flask
$(LIBXL_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenguest) $(CFLAGS_libxenstore) $(CFLAGS_libblktapctl) -include $(XEN_ROOT)/tools/config.h
-AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h
+AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h
AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \
libxlu_disk_l.o libxlu_disk.o libxlu_vif.o libxlu_pci.o
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2012-06-01 17:02 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-30 8:30 [xen-unstable test] 12988: regressions - FAIL xen.org
2012-05-30 9:44 ` Ian Campbell
2012-05-30 9:46 ` Ian Campbell
2012-05-30 9:57 ` Ian Jackson
2012-05-31 12:58 ` Ben Guthro
2012-05-31 13:04 ` Ben Guthro
2012-05-31 14:25 ` Ian Campbell
2012-05-31 15:10 ` Ian Jackson
2012-05-31 15:35 ` Ben Guthro
2012-06-01 16:48 ` Ian Campbell
2012-06-01 17:02 ` Ian Jackson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).