xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: xen-devel@lists.xen.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 0 of 4 RFC] Kexec path alteration
Date: Tue, 4 Dec 2012 18:16:07 +0000	[thread overview]
Message-ID: <patchbomb.1354644967@andrewcoop.uk.xensource.com> (raw)

I discovered a triple fault bug in the crash kernel while working on the
wider reentrant NMI/MCE issues discussed on the past few weeks on the
list.

As this is quite a substantial change, I present it here as an RFC ahead
of the longer series for reentrant behaviour (which I am still working
on).

I present patches 2 thru 4 simply as debugging aids for the bug fixed in
patch 1.  I am primarily rally concerned about RFC feedback from patch
1, although comments on patches 2 and 3 will not go amis, as they are
expected to be in the longer reentrant series.

Patch 4 is a debugkey '1' which deliberately creates reentrant NMIs and
stack corruption.  It is not intended for actually committing into the
codebase.

I am at a loss to explain why the triple fault is actually occurring; I
failed to get anything from early printk from the crash kernel, but did
not attempt to debug the extra gubbins which kexec puts in the blob.
The fault however is completely deterministic and can be verified by
commenting out the call to enable_nmis() in machine_kexec()

My setup is xen-unstable, 2.6.32-classic based dom0 and kdump kernels
with kexec-tools 2.0.2

~Andrew

             reply	other threads:[~2012-12-04 18:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04 18:16 Andrew Cooper [this message]
2012-12-04 18:16 ` [PATCH 1 of 4 RFC] x86/kexec: Change NMI and MCE handling on kexec path Andrew Cooper
2012-12-04 18:25   ` Andrew Cooper
2012-12-05  9:17   ` Jan Beulich
2012-12-05 10:05     ` Andrew Cooper
2012-12-06 11:36   ` Tim Deegan
2012-12-06 11:58     ` Andrew Cooper
2012-12-04 18:16 ` [PATCH 2 of 4 RFC] xen/panic: Introduce panic_in_progress Andrew Cooper
2012-12-04 18:16 ` [PATCH 3 of 4 RFC] x86/nmi: Prevent reentrant execution of the C nmi handler Andrew Cooper
2012-12-05  9:21   ` Jan Beulich
2012-12-05 10:47     ` Andrew Cooper
2012-12-06 11:39   ` Tim Deegan
2012-12-04 18:16 ` [PATCH 4 of 4 RFC] xen/nmi: DO NOT APPLY: debugkey to deliberatly invoke a reentrant NMI Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=patchbomb.1354644967@andrewcoop.uk.xensource.com \
    --to=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).