From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shriram R Subject: Re: xen-unstable build fails Date: Tue, 4 May 2010 23:31:20 -0700 Message-ID: References: <4BE10624.7020505@ts.fujitsu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1789336201==" Return-path: In-Reply-To: <4BE10624.7020505@ts.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Juergen Gross Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org --===============1789336201== Content-Type: multipart/alternative; boundary=00504502b1d6610b750485d2f974 --00504502b1d6610b750485d2f974 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable I thing Yang's patch is still not applied. And the build error is my mistake.. I missed the xen-hptool.c file changeset 21259:f7605c6c9548 changes the global suspend event channel lock file to a per-domain lock file, but do not update xc_suspend_evtchn_release() call in misc/hp-tool.c. So I got a build error when building tools. The patch fix this. Signed-off-by: Yang Hongyang diff -r efa1b905d893 tools/misc/xen-hptool.c --- a/tools/misc/xen-hptool.c Tue May 04 13:59:55 2010 +0100 +++ b/tools/misc/xen-hptool.c Wed May 05 19:56:51 2010 +0800 @@ -133,7 +133,7 @@ failed: if (suspend_evtchn !=3D -1) - xc_suspend_evtchn_release(xce, suspend_evtchn); + xc_suspend_evtchn_release(xce, domid, suspend_evtchn); return -1; } @@ -228,7 +228,7 @@ mfn, domid); } xc_domain_resume(xc_fd, domid, 1); - xc_suspend_evtchn_release(xce, suspend_evtchn); + xc_suspend_evtchn_release(xce, domid, suspend_evtchn); xc_evtchn_close(xce); } break; On Tue, May 4, 2010 at 10:46 PM, Juergen Gross wrote: > Hi, > > latest xen-unstable doesn't build on my machine: > > gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g > -fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-v= alue > -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .xen-hptool.o.d > -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Werror -I > ../../tools/python/xen/lowlevel/xc -I ../../tools/libxc -I > ../../tools/include -c -o xen-hptool.o xen-hptool.c > xen-hptool.c: In function =91suspend_guest=92: > xen-hptool.c:136: error: too few arguments to function > =91xc_suspend_evtchn_release=92 > xen-hptool.c: In function =91hp_mem_offline_func=92: > xen-hptool.c:231: error: too few arguments to function > =91xc_suspend_evtchn_release=92 > make[3]: *** [xen-hptool.o] Error 1 > make[3]: Leaving directory `/root/xen-unstable.hg/tools/misc' > > > Juergen > > -- > Juergen Gross Principal Developer Operating Systems > TSP ES&S SWE OS6 Telephone: +49 (0) 89 3222 2967 > Fujitsu Technology Solutions e-mail: > juergen.gross@ts.fujitsu.com > Domagkstr. 28 Internet: ts.fujitsu.com > D-80807 Muenchen Company details: > ts.fujitsu.com/imprint.html > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel > --=20 perception is but an offspring of its own self --00504502b1d6610b750485d2f974 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: quoted-printable I thing Yang's patch is still not applied. And the build error is my mi= stake.. I missed the xen-hptool.c file

changeset 21259:f7605c6c9548 = changes the global suspend event channel=20 lock file
to a per-domain lock file, but do not update xc_suspend_evtchn_release() call in
misc/hp-tool.c. So I got a build error when building tools. The patch=20 fix this.

Signed-off-by: Yang Hongyang <y= anghy@cn.fujitsu.com>

diff -r efa1b905d893 tools/misc/xen-hptool.c
--- a/tools/misc/xen-hptool.c =A0 Tue May 04 13:59:55 2010 +0100
+++ b/tools/misc/xen-hptool.c =A0 Wed May 05 19:56:51 2010 +0800
@@ -133,7 +133,7 @@

=A0failed:
=A0 =A0 if (suspend_evtchn !=3D -1)
- =A0 =A0 =A0 =A0xc_suspend_evtchn_release(xce, suspend_evtchn);
+ =A0 =A0 =A0 =A0xc_suspend_evtchn_release(xce, domid, suspend_evtchn);

=A0 =A0 return -1;
=A0}
@@ -228,7 +228,7 @@
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 mfn, domid= );
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 xc_domain_resume(xc_fd, domid, 1);=
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0xc_suspend_evtchn_release(xce, sus= pend_evtchn);
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0xc_suspend_evtchn_release(xce, dom= id,=20 suspend_evtchn);
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 xc_evtchn_close(xce);
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 break;


On Tue, May 4, 2010 at 10:46 PM, Juergen Gross <juergen.gross@ts.fujitsu.com> wrote:
Hi,

latest xen-unstable doesn't build on my machine:

gcc =A0-O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno= -strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -= Wdeclaration-after-statement =A0-D__XEN_TOOLS__ -MMD -MF .xen-hptool.o.d -D= _LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE =A0-Werror -I ../../tools/python/xe= n/lowlevel/xc -I ../../tools/libxc -I ../../tools/include -c -o xen-hptool.= o xen-hptool.c
xen-hptool.c: In function =91suspend_guest=92:
xen-hptool.c:136: error: too few arguments to function =91xc_suspend_evtchn= _release=92
xen-hptool.c: In function =91hp_mem_offline_func=92:
xen-hptool.c:231: error: too few arguments to function =91xc_suspend_evtchn= _release=92
make[3]: *** [xen-hptool.o] Error 1
make[3]: Leaving directory `/root/xen-unstable.hg/tools/misc'


Juergen

--
Juergen Gross =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Principal Developer Operating= Systems
TSP ES&S SWE OS6 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Telephone:= +49 (0) 89 3222 2967
Fujitsu Technology Solutions =A0 =A0 =A0 =A0 =A0 =A0 =A0e-mail: juergen.gross@ts.fuj= itsu.com
Domagkstr. 28 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Internet:= ts.fujitsu.com
D-80807 Muenchen =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Company details: ts.fujitsu.com/im= print.html

_______________________________________________
Xen-devel mailing list
Xen-deve= l@lists.xensource.com
http://l= ists.xensource.com/xen-devel



--
perception is but an of= fspring of its own self
--00504502b1d6610b750485d2f974-- --===============1789336201== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1789336201==--