* [tip:x86/irq] x86: Don't unmask disabled irqs when migrating them
@ 2011-05-19 12:55 tip-bot for Tian, Kevin
0 siblings, 0 replies; only message in thread
From: tip-bot for Tian, Kevin @ 2011-05-19 12:55 UTC (permalink / raw)
To: linux-tip-commits
Cc: kevin.tian, xen-devel, Ian.Campbell, fengzhe.zhang, JBeulich,
mingo, hpa, tglx
Commit-ID: 983bbf1af0664b78689612b247acb514300f62c7
Gitweb: http://git.kernel.org/tip/983bbf1af0664b78689612b247acb514300f62c7
Author: Tian, Kevin <kevin.tian@intel.com>
AuthorDate: Fri, 6 May 2011 14:43:56 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 19 May 2011 14:51:08 +0200
x86: Don't unmask disabled irqs when migrating them
It doesn't make sense to unconditionally unmask a disabled irq when
migrating it from offlined cpu to another. If the irq triggers then it
will be disabled in the interrupt handler anyway. So we can just avoid
unmasking it.
[ tglx: Made masking unconditional again and fixed the changelog ]
Signed-off-by: Fengzhe Zhang <fengzhe.zhang@intel.com>
Signed-off-by: Kevin Tian <kevin.tian@intel.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Link: http://lkml.kernel.org/r/%3C625BA99ED14B2D499DC4E29D8138F1505C8ED7F7E3%40shsmsx502.ccr.corp.intel.com%3E
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/irq.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index 544efe2..6c0802e 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -276,7 +276,8 @@ void fixup_irqs(void)
else if (!(warned++))
set_affinity = 0;
- if (!irqd_can_move_in_process_context(data) && chip->irq_unmask)
+ if (!irqd_can_move_in_process_context(data) &&
+ !irqd_irq_disabled(data) && chip->irq_unmask)
chip->irq_unmask(data);
raw_spin_unlock(&desc->lock);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-05-19 12:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-19 12:55 [tip:x86/irq] x86: Don't unmask disabled irqs when migrating them tip-bot for Tian, Kevin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).