Re: [PATCH Dovetail 6.18 v2 4/4] arm64: irq_pipeline: Fix tracepoint for multiplexed IPIs

[Philippe Gerum <rpm@xenomai.org>]

Florian Bezdeka <florian.bezdeka@siemens.com> writes:

> When IRQ pipelining is enabled the reason for an IPI was always set
> to IPI_RESCHEDULE as this is the IPI used for multiplexing all the
> inband IPIs via a single SGI/LPI.
>
> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> ---
>  arch/arm64/kernel/smp.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 53ec370235f93..39499b9797923 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -1069,9 +1069,10 @@ static void ipi_setup_oob_lpi(int ncpus)
>  		map_oob_ipis(cpu, nr_ipi);
>  }
>  
> -static void __smp_cross_call(const struct cpumask *target, unsigned int ipinr)
> +static void __smp_cross_call(const struct cpumask *target, unsigned int ipinr,
> +			     unsigned int msg)
>  {
> -	trace_ipi_raise(target, ipi_types[ipinr]);
> +	trace_ipi_raise(target, ipi_types[msg]);
>  	arm64_send_ipi(target, ipinr);
>  }
>  
> @@ -1102,7 +1103,7 @@ static void smp_cross_call(const struct cpumask *target, unsigned int ipinr)
>  {
>  	/* regular in-band IPI (multiplexed over SGI0). */
>  	set_ipi_message(target, ipinr);
> -	__smp_cross_call(target, 0);
> +	__smp_cross_call(target, 0, ipinr);
>  }
>  
>  static unsigned int get_ipi_count(int ipi, unsigned int cpu)
> @@ -1120,7 +1121,7 @@ void irq_send_oob_ipi(unsigned int irq, const struct cpumask *cpumask)
>  		return;
>  
>  	/* Out-of-band IPI (SGI1-3). */
> -	__smp_cross_call(cpumask, sgi);
> +	__smp_cross_call(cpumask, sgi, sgi);
>  }
>  EXPORT_SYMBOL_GPL(irq_send_oob_ipi);

Given the added complexity, I would rather not factor __smp_cross_call()
out anymore, open coding it in smp_cross_call() and irq_send_oob_ipi()
instead.

-- 
Philippe.