Re: [PATCH libevl] evl-test: fix opt parsing ignoring shifts

[Philippe Gerum <rpm@xenomai.org>]

Tobias Schaffner <tobias.schaffner@siemens.com> writes:

> The for loop used for opt parsing copies the list before iterating over
> its elements. Use a while loop to make the shift calls work as expected.
>
> Signed-off-by: Tobias Schaffner <tobias.schaffner@siemens.com>
> ---
>  utils/evl-test | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/utils/evl-test b/utils/evl-test
> index 0d0ca81..f17a781 100644
> --- a/utils/evl-test
> +++ b/utils/evl-test
> @@ -18,12 +18,13 @@ test_args=false
>  test_arg_list=
>  test_list=
>  
> -for opt
> +while test $# -gt 0
>  do
>      if test x$test_args = xtrue; then
> -	test_arg_list="$test_arg_list $opt"
> +	test_arg_list="$test_arg_list $1"
> +	shift
>      else
> -	case "$opt" in
> +	case "$1" in
>  	    -k) keep_going=true;
>  		shift;;
>  	    -h) help=true;
> @@ -39,7 +40,8 @@ do
>  	        exit 0;;
>  	    -*) usage $0
>  		exit 1;;
> -	    *)  test_list="$test_list $(eval echo $EVL_TESTDIR/$opt)"
> +	    *)  test_list="$test_list $(eval echo $EVL_TESTDIR/$1)"
> +		shift;;
>  	esac
>      fi
>  done

Merged (along with the typo fix in the help string), thanks.

-- 
Philippe.