XFS stable LTS mailing list
 help / color / mirror / Atom feed
From: <gregkh@linuxfoundation.org>
To: amir73il@gmail.com,catherine.hoang@oracle.com,chandan.babu@oracle.com,djwong@kernel.org,gregkh@linuxfoundation.org,hch@lst.de,leah.rumancik@gmail.com,xfs-stable@lists.linux.dev
Cc: <stable-commits@vger.kernel.org>
Subject: Patch "xfs: rt stubs should return negative errnos when rt disabled" has been added to the 6.1-stable tree
Date: Thu, 30 Jan 2025 09:41:01 +0100	[thread overview]
Message-ID: <2025013001-grant-anemia-3c53@gregkh> (raw)
In-Reply-To: <20250129184717.80816-5-leah.rumancik@gmail.com>


This is a note to let you know that I've just added the patch titled

    xfs: rt stubs should return negative errnos when rt disabled

to the 6.1-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     xfs-rt-stubs-should-return-negative-errnos-when-rt-disabled.patch
and it can be found in the queue-6.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


From stable+bounces-111215-greg=kroah.com@vger.kernel.org Wed Jan 29 19:47:47 2025
From: Leah Rumancik <leah.rumancik@gmail.com>
Date: Wed, 29 Jan 2025 10:47:02 -0800
Subject: xfs: rt stubs should return negative errnos when rt disabled
To: stable@vger.kernel.org
Cc: xfs-stable@lists.linux.dev, amir73il@gmail.com, chandan.babu@oracle.com, catherine.hoang@oracle.com, "Darrick J. Wong" <djwong@kernel.org>, Christoph Hellwig <hch@lst.de>, Leah Rumancik <leah.rumancik@gmail.com>
Message-ID: <20250129184717.80816-5-leah.rumancik@gmail.com>

From: "Darrick J. Wong" <djwong@kernel.org>

[ Upstream commit c2988eb5cff75c02bc57e02c323154aa08f55b78 ]

When realtime support is not compiled into the kernel, these functions
should return negative errnos, not positive errnos.  While we're at it,
fix a broken macro declaration.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 fs/xfs/xfs_rtalloc.h |   24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

--- a/fs/xfs/xfs_rtalloc.h
+++ b/fs/xfs/xfs_rtalloc.h
@@ -141,17 +141,17 @@ int xfs_rtalloc_extent_is_free(struct xf
 			       bool *is_free);
 int xfs_rtalloc_reinit_frextents(struct xfs_mount *mp);
 #else
-# define xfs_rtallocate_extent(t,b,min,max,l,f,p,rb)    (ENOSYS)
-# define xfs_rtfree_extent(t,b,l)                       (ENOSYS)
-# define xfs_rtfree_blocks(t,rb,rl)			(ENOSYS)
-# define xfs_rtpick_extent(m,t,l,rb)                    (ENOSYS)
-# define xfs_growfs_rt(mp,in)                           (ENOSYS)
-# define xfs_rtalloc_query_range(t,l,h,f,p)             (ENOSYS)
-# define xfs_rtalloc_query_all(m,t,f,p)                 (ENOSYS)
-# define xfs_rtbuf_get(m,t,b,i,p)                       (ENOSYS)
-# define xfs_verify_rtbno(m, r)			(false)
-# define xfs_rtalloc_extent_is_free(m,t,s,l,i)          (ENOSYS)
-# define xfs_rtalloc_reinit_frextents(m)                (0)
+# define xfs_rtallocate_extent(t,b,min,max,l,f,p,rb)	(-ENOSYS)
+# define xfs_rtfree_extent(t,b,l)			(-ENOSYS)
+# define xfs_rtfree_blocks(t,rb,rl)			(-ENOSYS)
+# define xfs_rtpick_extent(m,t,l,rb)			(-ENOSYS)
+# define xfs_growfs_rt(mp,in)				(-ENOSYS)
+# define xfs_rtalloc_query_range(m,t,l,h,f,p)		(-ENOSYS)
+# define xfs_rtalloc_query_all(m,t,f,p)			(-ENOSYS)
+# define xfs_rtbuf_get(m,t,b,i,p)			(-ENOSYS)
+# define xfs_verify_rtbno(m, r)				(false)
+# define xfs_rtalloc_extent_is_free(m,t,s,l,i)		(-ENOSYS)
+# define xfs_rtalloc_reinit_frextents(m)		(0)
 static inline int		/* error */
 xfs_rtmount_init(
 	xfs_mount_t	*mp)	/* file system mount structure */
@@ -162,7 +162,7 @@ xfs_rtmount_init(
 	xfs_warn(mp, "Not built with CONFIG_XFS_RT");
 	return -ENOSYS;
 }
-# define xfs_rtmount_inodes(m)  (((mp)->m_sb.sb_rblocks == 0)? 0 : (ENOSYS))
+# define xfs_rtmount_inodes(m)  (((mp)->m_sb.sb_rblocks == 0)? 0 : (-ENOSYS))
 # define xfs_rtunmount_inodes(m)
 #endif	/* CONFIG_XFS_RT */
 


Patches currently in stable-queue which might be from leah.rumancik@gmail.com are

queue-6.1/xfs-allow-read-io-and-ficlone-to-run-concurrently.patch
queue-6.1/xfs-hoist-freeing-of-rt-data-fork-extent-mappings.patch
queue-6.1/xfs-make-sure-maxlen-is-still-congruent-with-prod-when-rounding-down.patch
queue-6.1/xfs-only-remap-the-written-blocks-in-xfs_reflink_end_cow_extent.patch
queue-6.1/xfs-dquot-recovery-does-not-validate-the-recovered-dquot.patch
queue-6.1/xfs-clean-up-dqblk-extraction.patch
queue-6.1/xfs-abort-intent-items-when-recovery-intents-fail.patch
queue-6.1/xfs-up-ic_sema-if-flushing-data-device-fails.patch
queue-6.1/xfs-fix-internal-error-from-agfl-exhaustion.patch
queue-6.1/xfs-factor-out-xfs_defer_pending_abort.patch
queue-6.1/xfs-fix-units-conversion-error-in-xfs_bmap_del_extent_delay.patch
queue-6.1/xfs-bump-max-fsgeom-struct-version.patch
queue-6.1/xfs-handle-nimaps-0-from-xfs_bmapi_write-in-xfs_alloc_file_space.patch
queue-6.1/xfs-rt-stubs-should-return-negative-errnos-when-rt-disabled.patch
queue-6.1/xfs-clean-up-fs_xflag_realtime-handling-in-xfs_ioctl_setattr_xflags.patch
queue-6.1/xfs-respect-the-stable-writes-flag-on-the-rt-device.patch
queue-6.1/xfs-introduce-protection-for-drop-nlink.patch
queue-6.1/xfs-prevent-rt-growfs-when-quota-is-enabled.patch
queue-6.1/xfs-inode-recovery-does-not-validate-the-recovered-inode.patch

  reply	other threads:[~2025-01-30  8:41 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 18:46 [PATCH 6.1 00/19] xfs 6.1.y fixes from 6.7 Leah Rumancik
2025-01-29 18:46 ` [PATCH 6.1 01/19] xfs: bump max fsgeom struct version Leah Rumancik
2025-01-30  8:40   ` Patch "xfs: bump max fsgeom struct version" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 02/19] xfs: hoist freeing of rt data fork extent mappings Leah Rumancik
2025-01-30  8:41   ` Patch "xfs: hoist freeing of rt data fork extent mappings" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 03/19] xfs: prevent rt growfs when quota is enabled Leah Rumancik
2025-01-30  8:41   ` Patch "xfs: prevent rt growfs when quota is enabled" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 04/19] xfs: rt stubs should return negative errnos when rt disabled Leah Rumancik
2025-01-30  8:41   ` gregkh [this message]
2025-01-29 18:47 ` [PATCH 6.1 05/19] xfs: fix units conversion error in xfs_bmap_del_extent_delay Leah Rumancik
2025-01-30  8:41   ` Patch "xfs: fix units conversion error in xfs_bmap_del_extent_delay" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 06/19] xfs: make sure maxlen is still congruent with prod when rounding down Leah Rumancik
2025-01-30  8:41   ` Patch "xfs: make sure maxlen is still congruent with prod when rounding down" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 07/19] xfs: introduce protection for drop nlink Leah Rumancik
2025-01-30  8:41   ` Patch "xfs: introduce protection for drop nlink" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 08/19] xfs: handle nimaps=0 from xfs_bmapi_write in xfs_alloc_file_space Leah Rumancik
2025-01-30  8:41   ` Patch "xfs: handle nimaps=0 from xfs_bmapi_write in xfs_alloc_file_space" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 09/19] xfs: allow read IO and FICLONE to run concurrently Leah Rumancik
2025-01-30  8:40   ` Patch "xfs: allow read IO and FICLONE to run concurrently" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 10/19] xfs: factor out xfs_defer_pending_abort Leah Rumancik
2025-01-30  8:40   ` Patch "xfs: factor out xfs_defer_pending_abort" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 11/19] xfs: abort intent items when recovery intents fail Leah Rumancik
2025-01-30  8:40   ` Patch "xfs: abort intent items when recovery intents fail" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 12/19] xfs: only remap the written blocks in xfs_reflink_end_cow_extent Leah Rumancik
2025-01-30  8:41   ` Patch "xfs: only remap the written blocks in xfs_reflink_end_cow_extent" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 13/19] xfs: up(ic_sema) if flushing data device fails Leah Rumancik
2025-01-30  8:41   ` Patch "xfs: up(ic_sema) if flushing data device fails" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 14/19] xfs: fix internal error from AGFL exhaustion Leah Rumancik
2025-01-30  8:40   ` Patch "xfs: fix internal error from AGFL exhaustion" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 15/19] xfs: inode recovery does not validate the recovered inode Leah Rumancik
2025-01-30  8:41   ` Patch "xfs: inode recovery does not validate the recovered inode" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 16/19] xfs: clean up dqblk extraction Leah Rumancik
2025-01-30  8:40   ` Patch "xfs: clean up dqblk extraction" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 17/19] xfs: dquot recovery does not validate the recovered dquot Leah Rumancik
2025-01-30  8:40   ` Patch "xfs: dquot recovery does not validate the recovered dquot" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 18/19] xfs: clean up FS_XFLAG_REALTIME handling in xfs_ioctl_setattr_xflags Leah Rumancik
2025-01-30  8:40   ` Patch "xfs: clean up FS_XFLAG_REALTIME handling in xfs_ioctl_setattr_xflags" has been added to the 6.1-stable tree gregkh
2025-01-29 18:47 ` [PATCH 6.1 19/19] xfs: respect the stable writes flag on the RT device Leah Rumancik
2025-01-30  8:41   ` Patch "xfs: respect the stable writes flag on the RT device" has been added to the 6.1-stable tree gregkh
2025-01-30  8:41 ` [PATCH 6.1 00/19] xfs 6.1.y fixes from 6.7 Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025013001-grant-anemia-3c53@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=amir73il@gmail.com \
    --cc=catherine.hoang@oracle.com \
    --cc=chandan.babu@oracle.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=leah.rumancik@gmail.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=xfs-stable@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox