From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7F98224CC; Mon, 5 May 2025 09:19:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746436753; cv=none; b=nGNBD3+Ij8bI68HMgVztHP3ssAVT/x192YEzJuQyF6aU8HKIwxmlyOIMUwLmHNozNWoDhv7MKeN7D2GaPMzHG5BPjvx/dyU4JMIcJgkqiKrxa3TuUu1+YmM1JFG33Rm/+umYWdzaioQW1khSU45r3iIjc5TPSgbbh66brxMPuNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746436753; c=relaxed/simple; bh=TWg6Z6CFwyFAIph3BvoELm7EoA5VA9K+p77d/eBZj+o=; h=Subject:To:Cc:From:Date:In-Reply-To:Message-ID:MIME-Version: Content-Type; b=uvY9pdquxFyUSSfsBcMO7ujlemWR74u3kh8No7dQ0Ldrbi1LbXn8FRMdY2jFNpSgdFhmyDtXJJO7C5vRUqAGBs4c2ZphFtpRVVTq1FOAKu6RxB+nLEWwZ3Yv1QdflaQPsGya9qUHCtvFFTm8EaxMJjc6GB/bFDFvizJOR+Bi5uA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NU7BvBRd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NU7BvBRd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08AEFC4CEE4; Mon, 5 May 2025 09:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1746436752; bh=TWg6Z6CFwyFAIph3BvoELm7EoA5VA9K+p77d/eBZj+o=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=NU7BvBRdpZQQt9lSAXaZK1b5XLG5jb8QhWjexpjW4as2akZ3OzJTEdejNzQ3psEvK C5iH4LFp5radU1tC3t4/+1cxndWnxPP2JylmnAVx8QwsASfmsAtqEv1rDpPkE7EtuK KrJXp22K22wYSGWzV+7inol2cCNTR/zSpqTMLn8A= Subject: Patch "xfs: revert commit 44af6c7e59b12" has been added to the 6.1-stable tree To: catherine.hoang@oracle.com,chandan.babu@oracle.com,djwong@kernel.org,gregkh@linuxfoundation.org,hch@lst.de,leah.rumancik@gmail.com,xfs-stable@lists.linux.dev Cc: From: Date: Mon, 05 May 2025 11:18:25 +0200 In-Reply-To: <20250430212704.2905795-8-leah.rumancik@gmail.com> Message-ID: <2025050525-matchless-reverse-b4c6@gregkh> Precedence: bulk X-Mailing-List: xfs-stable@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit X-stable: commit X-Patchwork-Hint: ignore This is a note to let you know that I've just added the patch titled xfs: revert commit 44af6c7e59b12 to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: xfs-revert-commit-44af6c7e59b12.patch and it can be found in the queue-6.1 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From stable+bounces-139234-greg=kroah.com@vger.kernel.org Wed Apr 30 23:32:49 2025 From: Leah Rumancik Date: Wed, 30 Apr 2025 14:26:54 -0700 Subject: xfs: revert commit 44af6c7e59b12 To: stable@vger.kernel.org Cc: xfs-stable@lists.linux.dev, chandan.babu@oracle.com, catherine.hoang@oracle.com, djwong@kernel.org, Christoph Hellwig , Leah Rumancik Message-ID: <20250430212704.2905795-8-leah.rumancik@gmail.com> From: "Darrick J. Wong" [ Upstream commit 2a009397eb5ae178670cbd7101e9635cf6412b35 ] In my haste to fix what I thought was a performance problem in the attr scrub code, I neglected to notice that the xfs_attr_get_ilocked also had the effect of checking that attributes can actually be looked up through the attr dabtree. Fix this. Fixes: 44af6c7e59b12 ("xfs: don't load local xattr values during scrub") Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Leah Rumancik Acked-by: "Darrick J. Wong" Signed-off-by: Greg Kroah-Hartman --- fs/xfs/scrub/attr.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/fs/xfs/scrub/attr.c +++ b/fs/xfs/scrub/attr.c @@ -159,6 +159,11 @@ xchk_xattr_listent( args.value = xchk_xattr_valuebuf(sx->sc); args.valuelen = valuelen; + /* + * Get the attr value to ensure that lookup can find this attribute + * through the dabtree indexing and that remote value retrieval also + * works correctly. + */ error = xfs_attr_get_ilocked(&args); /* ENODATA means the hash lookup failed and the attr is bad */ if (error == -ENODATA) Patches currently in stable-queue which might be from leah.rumancik@gmail.com are queue-6.1/xfs-revert-commit-44af6c7e59b12.patch queue-6.1/xfs-make-the-seq-argument-to-xfs_bmapi_convert_delalloc-optional.patch queue-6.1/xfs-check-opcode-and-iovec-count-match-in-xlog_recover_attri_commit_pass2.patch queue-6.1/xfs-allow-symlinks-with-short-remote-targets.patch queue-6.1/xfs-match-lock-mode-in-xfs_buffered_write_iomap_begin.patch queue-6.1/xfs-require-xfs_sb_feat_incompat_log_xattrs-for-attr-log-intent-item-recovery.patch queue-6.1/xfs-allow-unlinked-symlinks-and-dirs-with-zero-size.patch queue-6.1/xfs-restrict-when-we-try-to-align-cow-fork-delalloc-to-cowextsz-hints.patch queue-6.1/xfs-fix-xfs_bmap_add_extent_delay_real-for-partial-conversions.patch queue-6.1/xfs-validate-recovered-name-buffers-when-recovering-xattr-items.patch queue-6.1/xfs-make-xfs_bmapi_convert_delalloc-to-allocate-the-target-offset.patch queue-6.1/xfs-convert-delayed-extents-to-unwritten-when-zeroing-post-eof-blocks.patch queue-6.1/xfs-fix-freeing-speculative-preallocations-for-preallocated-files.patch queue-6.1/xfs-make-sure-sb_fdblocks-is-non-negative.patch queue-6.1/xfs-remove-a-racy-if_bytes-check-in-xfs_reflink_end_cow_extent.patch queue-6.1/xfs-fix-error-returns-from-xfs_bmapi_write.patch