Re: [docs] [PATCH] contributor-guide: recommend format.forceInBodyFrom

Alexander Kanavin
2024-05-02T20:54:11Z

On Thu, 2 May 2024 at 22:23, Tim Orling <tim.orling@konsulko.com> wrote:
> The reason for this thread was a comment from RP during the YP Bug Triage meeting that things were different recently, so we are trying to make sure we get this correct.
> Either something changed in groups.io or somewhere else, because my setup only added either of these settings today.
> I have just sent three emails with the same exact patch but different settings to test-list
> (1) both sendemail.from and format.forceInBodyFrom
> (2) only sendemail.from
> (3) neither sendemail.from nor format.forceInBodyFrom
>
> #3 is also the same conditions I used to send the original patch to the oe-core list.
>
> I would have expected to have heard from Alexandre Belloni previously that there was an issue with my setup in #3.

Right so my observations are:

- groups.io sometimes mangles From (with this 'via list' stuff) and
sometimes it doesn't. I can't see a pattern other than it used to
happen less, and lately it seems to happen for everyone including RP
:-/

- git will insert From: into the body when the patch author and
sendemail.from are not the same (as I set up for myself). It will not
do this if they are the same, even when --force-in-body-from is added
or set in a global config. I'm not sure what am I doing wrong, but it
just doesn't work for me :-/ git is at 2.39.2, so maybe this is fixed
in later versions?

Alex